From: Chen Gang <gang.chen@asianux.com>
To: venkat.x.venkatsubra@oracle.com,
David Miller <davem@davemloft.net>,
rds-devel@oss.oracle.com, netdev <netdev@vger.kernel.org>
Subject: [PATCH] net/rds: using strlcpy instead of strncpy
Date: Thu, 28 Feb 2013 16:28:36 +0800 [thread overview]
Message-ID: <512F1534.9020404@asianux.com> (raw)
when src strlen is sizeof(ctr.name) - 1, the dest str is not '\0' end.
better use strlcpy instead.
Signed-off-by: Chen Gang <gang.chen@asianux.com>
---
net/rds/stats.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/net/rds/stats.c b/net/rds/stats.c
index 7be790d..b9ac1df 100644
--- a/net/rds/stats.c
+++ b/net/rds/stats.c
@@ -86,7 +86,7 @@ void rds_stats_info_copy(struct rds_info_iterator *iter,
for (i = 0; i < nr; i++) {
BUG_ON(strlen(names[i]) >= sizeof(ctr.name));
- strncpy(ctr.name, names[i], sizeof(ctr.name) - 1);
+ strlcpy(ctr.name, names[i], sizeof(ctr.name));
ctr.value = values[i];
rds_info_copy(iter, &ctr, sizeof(ctr));
--
1.7.7.6
next reply other threads:[~2013-02-28 8:28 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-28 8:28 Chen Gang [this message]
2013-02-28 9:36 ` [PATCH] net/rds: using strlcpy instead of strncpy David Laight
2013-02-28 10:26 ` Chen Gang
2013-03-04 18:32 ` Ben Hutchings
2013-03-04 18:34 ` Ben Hutchings
2013-03-05 2:32 ` Chen Gang
2013-03-05 3:16 ` Ben Hutchings
2013-03-05 3:32 ` Chen Gang
2013-03-05 3:37 ` Ben Hutchings
2013-03-05 4:09 ` Chen Gang
2013-03-05 17:00 ` Ben Hutchings
2013-03-07 4:03 ` Chen Gang
2013-03-08 3:19 ` [PATCH] net/rds: zero last byte for strncpy Chen Gang
2013-03-08 5:36 ` David Miller
2013-03-08 6:13 ` Chen Gang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=512F1534.9020404@asianux.com \
--to=gang.chen@asianux.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=rds-devel@oss.oracle.com \
--cc=venkat.x.venkatsubra@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.