From: mkl@pengutronix.de (Marc Kleine-Budde)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/3] USB: add devicetree helpers for determining dr_mode and phy_type
Date: Thu, 28 Feb 2013 10:23:03 +0100 [thread overview]
Message-ID: <512F21F7.5050903@pengutronix.de> (raw)
In-Reply-To: <20130228075755.GA6544@arwen.pp.htv.fi>
On 02/28/2013 08:57 AM, Felipe Balbi wrote:
> On Wed, Feb 27, 2013 at 03:16:29PM +0100, Marc Kleine-Budde wrote:
>> From: Michael Grzeschik <m.grzeschik@pengutronix.de>
>>
>> This adds two little devicetree helper functions for determining the dr_mode
>> (host, peripheral, otg, dual-role) and phy_type (utmi, ulpi,...) from the
>> devicetree.
>>
>> Cc: Felipe Balbi <balbi@ti.com>
>> Signed-off-by: Michael Grzeschik <m.grzeschik@pengutronix.de>
>> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
>> Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
>
> causes build breakage:
>
> include/linux/usb/of.h:21:32: error: return type is an incomplete type
> include/linux/usb/of.h: In function ?of_usb_get_dr_mode?:
> include/linux/usb/of.h:23:9: error: ?USB_DR_MODE_UNKNOWN? undeclared (first use in this function)
> include/linux/usb/of.h:23:9: note: each undeclared identifier is reported only once for each function it appears in
> include/linux/usb/of.h:23:2: warning: ?return? with a value, in function returning void [enabled by default]
> make[1]: *** [drivers/usb/usb-common.o] Error 1
Doh! That occurs only for non DT kernels, but who doesn't use device
tree these days?
Fixed,
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions | Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 263 bytes
Desc: OpenPGP digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20130228/6943c07f/attachment.sig>
next prev parent reply other threads:[~2013-02-28 9:23 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-27 14:16 [PATCH 0/3] otg-for-v3.10-v1: separate phy code and add DT helper Marc Kleine-Budde
2013-02-27 14:16 ` [PATCH 1/3] USB: move bulk of otg/otg.c to phy/phy.c Marc Kleine-Budde
2013-02-27 14:16 ` [PATCH 2/3] USB: add devicetree helpers for determining dr_mode and phy_type Marc Kleine-Budde
2013-02-28 7:57 ` Felipe Balbi
2013-02-28 9:23 ` Marc Kleine-Budde [this message]
2013-02-28 11:16 ` Felipe Balbi
2013-02-27 14:16 ` [PATCH 3/3] USB mxs-phy: Register phy with framework Marc Kleine-Budde
2013-02-28 8:01 ` Felipe Balbi
2013-02-28 9:21 ` Marc Kleine-Budde
2013-02-28 9:40 ` Alexander Shishkin
2013-02-28 10:55 ` Marc Kleine-Budde
2013-02-27 16:29 ` [PATCH 0/3] otg-for-v3.10-v1: separate phy code and add DT helper Steffen Trumtrar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=512F21F7.5050903@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.