From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Vrabel <david.vrabel@citrix.com>
Subject: Re: [RFC PATCH V3 19/22] Enable exteneded event channel
	ABI query
Date: Thu, 28 Feb 2013 12:36:39 +0000
Message-ID: <512F4F57.4020101@citrix.com>
References: <1361975655-22295-1-git-send-email-wei.liu2@citrix.com>
	<1361975655-22295-20-git-send-email-wei.liu2@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1361975655-22295-20-git-send-email-wei.liu2@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Wei Liu <wei.liu2@citrix.com>
Cc: "Keir (Xen.org)" <keir@xen.org>, Ian Campbell <Ian.Campbell@citrix.com>, "jbeulich@suse.com" <jbeulich@suse.com>, "xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
List-Id: xen-devel@lists.xenproject.org

On 27/02/13 14:34, Wei Liu wrote:
> --- a/xen/common/event_channel.c
> +++ b/xen/common/event_channel.c
> @@ -1219,12 +1219,14 @@ static long evtchn_register_extended(struct evtchn_register_extended *reg)
>  
>      switch ( reg->cmd )
>      {
> -    case EVTCHN_EXTENDED_NONE:
> -    default:
> -        rc = -EINVAL;
> +    case EVTCHN_EXTENDED_QUERY:
> +        rc = extended_event_channel;
> +        break;

I don't like overloading the return value with both success/failure and
the data.

Can this info be returned in a parameter?

David