From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Vrabel Subject: Re: [RFC PATCH V3 22/22] libxl: add evtchn_extended flag Date: Thu, 28 Feb 2013 12:48:17 +0000 Message-ID: <512F5211.3020900@citrix.com> References: <1361975655-22295-1-git-send-email-wei.liu2@citrix.com> <1361975655-22295-23-git-send-email-wei.liu2@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1361975655-22295-23-git-send-email-wei.liu2@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Wei Liu Cc: "Keir (Xen.org)" , Ian Campbell , "jbeulich@suse.com" , "xen-devel@lists.xen.org" List-Id: xen-devel@lists.xenproject.org On 27/02/13 14:34, Wei Liu wrote: > Admins can add "evtchn_extended = 1" in domain config file to enable extended > event channel ABI for a domain. You haven't added any documentation for this new option. I think an option to limit the number of event channels is more intuitive for the guest administrator. See also my comment on patch 21. When you come to write documentation that is useful for a host administrator or toolstack author for what "evtchn_extended" actually means you'll see what I mean. Particularly when you have to say it means slightly different things depending on whether you're on ARM or on 32 or 64-bit x86. David