From: Shrikanth Hegde <sshegde@linux.ibm.com>
To: Fushuai Wang <fushuai.wang@linux.dev>
Cc: linux-kernel@vger.kernel.org, wangfushuai@baidu.com,
mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com,
vincent.guittot@linaro.org, dietmar.eggemann@arm.com,
rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de,
vschneid@redhat.com, kprateek.nayak@amd.com
Subject: Re: [PATCH v2] sched/core: Fix a TOCTOU bug in sched_non_preferred_cpu_push_stop()
Date: Wed, 18 Nov 2026 14:36:01 +0530 [thread overview]
Message-ID: <512ba302-9dcd-4ce4-9331-a6e545c36a8a@linux.ibm.com> (raw)
In-Reply-To: <20261118065921.98260-1-fushuai.wang@linux.dev>
Hi Fushuai. Thanks for the fix.
On 11/18/26 12:29 PM, Fushuai Wang wrote:
> From: Fushuai Wang <wangfushuai@baidu.com>
>
> sched_push_current_non_preferred_cpu() is called in irq context. It
> checks is_migration_disabled() before queuing the stopper.
>
> migrate_disable() sets p->migration_disabled in preempt_disable() section.
> An irq can hit after preempt_disable() but before p->migration_disabled=1.
> After the irq returns, the task cannot be preempted by stopper becuase
> preemption is disabled, so it finishes setting p->migration_disabled=1
> before the stopper runs.
>
> It may be like:
> task context: irq context:
> migrate_disable()
> preempt_disable()
> is_migration_disabled()
> migration_disabled = 1
> preempt_enable()
>
> So recheck is_migration_disabled() in sched_non_preferred_cpu_push_stop()
> before calling __migrate_task().
>
> The stack may be like:
> WARNING: kernel/sched/core.c:3432 at set_task_cpu+0x1b8/0xdf0, CPU#21: migration/21/152
> CPU: 21 UID: 0 PID: 152 Comm: migration/21 Tainted: G W O 7.4.0-rc1 #3 PREEMPT(lazy)
> Stopper: sched_non_preferred_cpu_push_stop+0x0/0xb10 <- sched_push_current_non_preferred_cpu+0x6a6/0x9a0
> RIP: 0010:set_task_cpu+0x1b8/0xdf0
> Call Trace:
> <TASK>
> ? set_task_cpu+0x5/0xdf0
> move_queued_task+0xfc/0x650
> ? is_cpu_allowed+0x341/0x820
> ? __this_cpu_preempt_check+0x13/0x20
> sched_non_preferred_cpu_push_stop+0x7b7/0xb10
> ? __this_cpu_preempt_check+0x13/0x20
> ? __pfx_sched_non_preferred_cpu_push_stop+0x10/0x10
> ? __pfx_sched_non_preferred_cpu_push_stop+0x10/0x10
> ? sched_non_preferred_cpu_push_stop+0x5/0xb10
> ? __pfx_sched_non_preferred_cpu_push_stop+0x10/0x10
> cpu_stopper_thread+0x205/0x410
> ? smpboot_thread_fn+0x307/0xa60
> ? __pfx_cpu_stopper_thread+0x10/0x10
> smpboot_thread_fn+0x352/0xa60
> ? __pfx_smpboot_thread_fn+0x10/0x10
> kthread+0x3a6/0x4d0
> ? __pfx_kthread+0x10/0x10
> ret_from_fork+0x68e/0xb40
> ? __pfx_ret_from_fork+0x10/0x10
> ? __kasan_check_read+0x11/0x20
> ? __switch_to+0x592/0x1210
> ? __pfx_kthread+0x10/0x10
> ret_from_fork_asm+0x1a/0x30
> </TASK>
>
> Fixes: 74699f56ebcf ("sched/core: Push current task from non preferred CPU")
> Signed-off-by: Fushuai Wang <wangfushuai@baidu.com>
Reviewed-by: Shrikanth Hegde <sshegde@linux.ibm.com>
> ---
> v1->v2: No code changes, just improve the commit message.
>
> kernel/sched/core.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/kernel/sched/core.c b/kernel/sched/core.c
> index 5ed660f099a5..6f9374aa3f19 100644
> --- a/kernel/sched/core.c
> +++ b/kernel/sched/core.c
> @@ -11314,7 +11314,8 @@ static int sched_non_preferred_cpu_push_stop(void *arg)
> rq->npc_push_work_pending = false;
> update_rq_clock(rq);
>
> - if (task_rq(p) == rq && task_on_rq_queued(p)) {
> + if (task_rq(p) == rq && task_on_rq_queued(p) &&
> + !is_migration_disabled(p)) {
> struct rq *dest_rq = __migrate_task(rq, &rf, p, cpu);
>
> if (rq != dest_rq)
prev parent reply other threads:[~2026-11-18 9:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-18 6:59 [PATCH v2] sched/core: Fix a TOCTOU bug in sched_non_preferred_cpu_push_stop() Fushuai Wang
2026-11-18 9:06 ` Shrikanth Hegde [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=512ba302-9dcd-4ce4-9331-a6e545c36a8a@linux.ibm.com \
--to=sshegde@linux.ibm.com \
--cc=bsegall@google.com \
--cc=dietmar.eggemann@arm.com \
--cc=fushuai.wang@linux.dev \
--cc=juri.lelli@redhat.com \
--cc=kprateek.nayak@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=vincent.guittot@linaro.org \
--cc=vschneid@redhat.com \
--cc=wangfushuai@baidu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.