From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexey Kardashevskiy Subject: Re: [PATCH 1/6 v8] iommu/fsl: Store iommu domain information pointer in archdata. Date: Fri, 01 Mar 2013 12:24:55 +1100 Message-ID: <51300367.6080300@ozlabs.ru> References: <1361191939-21260-1-git-send-email-Varun.Sethi@freescale.com> <1361191939-21260-2-git-send-email-Varun.Sethi@freescale.com> <20130227113045.GH26252@8bytes.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Kumar Gala Cc: Wood Scott-B07421 , Benjamin Herrenschmidt , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org list" , Yoder Stuart-B08248 , iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, Paul Mackerras , "linuxppc-dev-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org list" , David Gibson List-Id: iommu@lists.linux-foundation.org Hi! On POWERNV we use only the part of IOMMU API which handles devices and groups. We do not use IOMMU domains as VFIO containers do everything we need for VFIO and we do not implement iommu_ops as it is not very relevant to our architecture (does not give dma window properties, etc). So your work does not overlap with my work :) On 01/03/13 02:51, Kumar Gala wrote: > > On Feb 27, 2013, at 6:04 AM, Sethi Varun-B16395 wrote: > >> Hi Kumar,Ben, >> I am implementing the Freescale PAMU (IOMMU) driver using the Linux IOMMU API. In this particular patch, I have added a new field to dev_archdata structure to store the dma domain information. >> This field is updated whenever we attach a device to an iommu domain. >> >> Regards >> Varun > > Would be good to see if this overlaps with Alexey's work for IOMMU driver for powernv. > > - k > >> >>> -----Original Message----- >>> From: Joerg Roedel [mailto:joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org] >>> Sent: Wednesday, February 27, 2013 5:01 PM >>> To: Sethi Varun-B16395 >>> Cc: iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org; linuxppc-dev-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org; >>> linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org; Wood Scott-B07421; Yoder Stuart-B08248 >>> Subject: Re: [PATCH 1/6 v8] iommu/fsl: Store iommu domain information >>> pointer in archdata. >>> >>> On Mon, Feb 18, 2013 at 06:22:14PM +0530, Varun Sethi wrote: >>>> Add a new field in the device (powerpc) archdata structure for storing >>>> iommu domain information pointer. This pointer is stored when the >>>> device is attached to a particular domain. >>>> >>>> >>>> Signed-off-by: Varun Sethi >>>> --- >>>> - no change. >>>> arch/powerpc/include/asm/device.h | 4 ++++ >>>> 1 files changed, 4 insertions(+), 0 deletions(-) >>>> >>>> diff --git a/arch/powerpc/include/asm/device.h >>>> b/arch/powerpc/include/asm/device.h >>>> index 77e97dd..6dc79fe 100644 >>>> --- a/arch/powerpc/include/asm/device.h >>>> +++ b/arch/powerpc/include/asm/device.h >>>> @@ -28,6 +28,10 @@ struct dev_archdata { >>>> void *iommu_table_base; >>>> } dma_data; >>>> >>>> + /* IOMMU domain information pointer. This would be set >>>> + * when this device is attached to an iommu_domain. >>>> + */ >>>> + void *iommu_domain; >>> >>> Please Cc the PowerPC Maintainers on this, so that they can have a look >>> at it. This also must be put this into an #ifdef CONFIG_IOMMU_API. -- Alexey From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ob0-x232.google.com (mail-ob0-x232.google.com [IPv6:2607:f8b0:4003:c01::232]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority" (not verified)) by ozlabs.org (Postfix) with ESMTPS id DEFC22C02CA for ; Fri, 1 Mar 2013 12:24:12 +1100 (EST) Received: by mail-ob0-f178.google.com with SMTP id wd20so595699obb.23 for ; Thu, 28 Feb 2013 17:24:07 -0800 (PST) Message-ID: <51300367.6080300@ozlabs.ru> Date: Fri, 01 Mar 2013 12:24:55 +1100 From: Alexey Kardashevskiy MIME-Version: 1.0 To: Kumar Gala Subject: Re: [PATCH 1/6 v8] iommu/fsl: Store iommu domain information pointer in archdata. References: <1361191939-21260-1-git-send-email-Varun.Sethi@freescale.com> <1361191939-21260-2-git-send-email-Varun.Sethi@freescale.com> <20130227113045.GH26252@8bytes.org> In-Reply-To: Content-Type: text/plain; charset=KOI8-R; format=flowed Cc: Wood Scott-B07421 , Alex Williamson , Joerg Roedel , "linux-kernel@vger.kernel.org list" , Yoder Stuart-B08248 , iommu@lists.linux-foundation.org, Paul Mackerras , Sethi Varun-B16395 , "linuxppc-dev@lists.ozlabs.org list" , David Gibson List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Hi! On POWERNV we use only the part of IOMMU API which handles devices and groups. We do not use IOMMU domains as VFIO containers do everything we need for VFIO and we do not implement iommu_ops as it is not very relevant to our architecture (does not give dma window properties, etc). So your work does not overlap with my work :) On 01/03/13 02:51, Kumar Gala wrote: > > On Feb 27, 2013, at 6:04 AM, Sethi Varun-B16395 wrote: > >> Hi Kumar,Ben, >> I am implementing the Freescale PAMU (IOMMU) driver using the Linux IOMMU API. In this particular patch, I have added a new field to dev_archdata structure to store the dma domain information. >> This field is updated whenever we attach a device to an iommu domain. >> >> Regards >> Varun > > Would be good to see if this overlaps with Alexey's work for IOMMU driver for powernv. > > - k > >> >>> -----Original Message----- >>> From: Joerg Roedel [mailto:joro@8bytes.org] >>> Sent: Wednesday, February 27, 2013 5:01 PM >>> To: Sethi Varun-B16395 >>> Cc: iommu@lists.linux-foundation.org; linuxppc-dev@lists.ozlabs.org; >>> linux-kernel@vger.kernel.org; Wood Scott-B07421; Yoder Stuart-B08248 >>> Subject: Re: [PATCH 1/6 v8] iommu/fsl: Store iommu domain information >>> pointer in archdata. >>> >>> On Mon, Feb 18, 2013 at 06:22:14PM +0530, Varun Sethi wrote: >>>> Add a new field in the device (powerpc) archdata structure for storing >>>> iommu domain information pointer. This pointer is stored when the >>>> device is attached to a particular domain. >>>> >>>> >>>> Signed-off-by: Varun Sethi >>>> --- >>>> - no change. >>>> arch/powerpc/include/asm/device.h | 4 ++++ >>>> 1 files changed, 4 insertions(+), 0 deletions(-) >>>> >>>> diff --git a/arch/powerpc/include/asm/device.h >>>> b/arch/powerpc/include/asm/device.h >>>> index 77e97dd..6dc79fe 100644 >>>> --- a/arch/powerpc/include/asm/device.h >>>> +++ b/arch/powerpc/include/asm/device.h >>>> @@ -28,6 +28,10 @@ struct dev_archdata { >>>> void *iommu_table_base; >>>> } dma_data; >>>> >>>> + /* IOMMU domain information pointer. This would be set >>>> + * when this device is attached to an iommu_domain. >>>> + */ >>>> + void *iommu_domain; >>> >>> Please Cc the PowerPC Maintainers on this, so that they can have a look >>> at it. This also must be put this into an #ifdef CONFIG_IOMMU_API. -- Alexey From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754380Ab3CABYK (ORCPT ); Thu, 28 Feb 2013 20:24:10 -0500 Received: from mail-oa0-f51.google.com ([209.85.219.51]:34493 "EHLO mail-oa0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754244Ab3CABYH (ORCPT ); Thu, 28 Feb 2013 20:24:07 -0500 Message-ID: <51300367.6080300@ozlabs.ru> Date: Fri, 01 Mar 2013 12:24:55 +1100 From: Alexey Kardashevskiy User-Agent: Mozilla/5.0 (X11; Linux i686 on x86_64; rv:17.0) Gecko/20130107 Thunderbird/17.0.2 MIME-Version: 1.0 To: Kumar Gala CC: Sethi Varun-B16395 , Benjamin Herrenschmidt , iommu@lists.linux-foundation.org, "linuxppc-dev@lists.ozlabs.org list" , "linux-kernel@vger.kernel.org list" , Wood Scott-B07421 , Yoder Stuart-B08248 , Joerg Roedel , Paul Mackerras , David Gibson , Alex Williamson Subject: Re: [PATCH 1/6 v8] iommu/fsl: Store iommu domain information pointer in archdata. References: <1361191939-21260-1-git-send-email-Varun.Sethi@freescale.com> <1361191939-21260-2-git-send-email-Varun.Sethi@freescale.com> <20130227113045.GH26252@8bytes.org> In-Reply-To: Content-Type: text/plain; charset=KOI8-R; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi! On POWERNV we use only the part of IOMMU API which handles devices and groups. We do not use IOMMU domains as VFIO containers do everything we need for VFIO and we do not implement iommu_ops as it is not very relevant to our architecture (does not give dma window properties, etc). So your work does not overlap with my work :) On 01/03/13 02:51, Kumar Gala wrote: > > On Feb 27, 2013, at 6:04 AM, Sethi Varun-B16395 wrote: > >> Hi Kumar,Ben, >> I am implementing the Freescale PAMU (IOMMU) driver using the Linux IOMMU API. In this particular patch, I have added a new field to dev_archdata structure to store the dma domain information. >> This field is updated whenever we attach a device to an iommu domain. >> >> Regards >> Varun > > Would be good to see if this overlaps with Alexey's work for IOMMU driver for powernv. > > - k > >> >>> -----Original Message----- >>> From: Joerg Roedel [mailto:joro@8bytes.org] >>> Sent: Wednesday, February 27, 2013 5:01 PM >>> To: Sethi Varun-B16395 >>> Cc: iommu@lists.linux-foundation.org; linuxppc-dev@lists.ozlabs.org; >>> linux-kernel@vger.kernel.org; Wood Scott-B07421; Yoder Stuart-B08248 >>> Subject: Re: [PATCH 1/6 v8] iommu/fsl: Store iommu domain information >>> pointer in archdata. >>> >>> On Mon, Feb 18, 2013 at 06:22:14PM +0530, Varun Sethi wrote: >>>> Add a new field in the device (powerpc) archdata structure for storing >>>> iommu domain information pointer. This pointer is stored when the >>>> device is attached to a particular domain. >>>> >>>> >>>> Signed-off-by: Varun Sethi >>>> --- >>>> - no change. >>>> arch/powerpc/include/asm/device.h | 4 ++++ >>>> 1 files changed, 4 insertions(+), 0 deletions(-) >>>> >>>> diff --git a/arch/powerpc/include/asm/device.h >>>> b/arch/powerpc/include/asm/device.h >>>> index 77e97dd..6dc79fe 100644 >>>> --- a/arch/powerpc/include/asm/device.h >>>> +++ b/arch/powerpc/include/asm/device.h >>>> @@ -28,6 +28,10 @@ struct dev_archdata { >>>> void *iommu_table_base; >>>> } dma_data; >>>> >>>> + /* IOMMU domain information pointer. This would be set >>>> + * when this device is attached to an iommu_domain. >>>> + */ >>>> + void *iommu_domain; >>> >>> Please Cc the PowerPC Maintainers on this, so that they can have a look >>> at it. This also must be put this into an #ifdef CONFIG_IOMMU_API. -- Alexey