All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vipin Kumar <vipin.kumar@st.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [Drivers PATCH 14/19] net/macb: workaround for transmission hang issue
Date: Fri, 1 Mar 2013 09:10:31 +0530	[thread overview]
Message-ID: <5130232F.9000002@st.com> (raw)
In-Reply-To: <51301BBD.7050308@atmel.com>

On 3/1/2013 8:38 AM, Bo Shen wrote:
> Hi All,
>
> On 02/28/2013 08:59 PM, Albert ARIBAUD wrote:
>> On Sun, 3 Feb 2013 12:19:26 +0100, Albert ARIBAUD
>> <albert.u.boot@aribaud.net> wrote:
>>
>>> Hi Vipin,
>>>
>>> On Fri, 2 Nov 2012 23:09:59 +0530, Vipin Kumar<vipin.kumar@st.com>
>>> wrote:
>>>
>>>> From: Shiraz Hashim<shiraz.hashim@st.com>
>>>>
>>>> It is observed on SPEAr320S RMII#1 interface that on transmitting
>>>> packets the MAC dma hangs randomly and constantly showing busy tx-go
>>>> state.
>>>>
>>>> It comes out if this situation only when Transmission is disabled and
>>>> enabled again.
>>>>
>>>> Since it happens randomly and u-boot doesn't require high
>>>> performance we
>>>> disable TE and re-enable it on each transmission. We also change number
>>>> of transmit descriptor to 1 as we would not require more than it,
>>>> further
>>>> it would not alter GMAC notion of transmit descriptor start queue as it
>>>> always point to same descriptor.
>>>>
>>>> Signed-off-by: Shiraz Hashim<shiraz.hashim@st.com>
>>>> ---
>>>> drivers/net/macb.c | 38 ++++++++++++++++++++++++++++++++++----
>>>> 1 file changed, 34 insertions(+), 4 deletions(-)
>
> Tested on Atmel EK board. It works.
>
> Tested-by: Bo Shen <voice.shen@atmel.com>
>
> BTW, would this be implemented as a workaround only for SPEAr320S?
>

Yes, The idea was to implement this only for spear320s
After your tested-by, I am thinking may be I can make a separate 
workaround config which can be enabled by any board using this peripheral.

Is that OK?

Regards
Vipin

  reply	other threads:[~2013-03-01  3:40 UTC|newest]

Thread overview: 72+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <cover.1351876757.git.vipin.kumar@st.com>
2012-11-02 17:39 ` [U-Boot] [Drivers PATCH 01/19] mtd/st_smi: Clear error flags while initiating a fresh write Vipin Kumar
2012-11-02 17:39   ` [U-Boot] [Drivers PATCH 02/19] mtd/st_smi: Add support for Micron N25Q128 Flash Vipin Kumar
2012-11-02 17:39   ` [U-Boot] [Drivers PATCH 03/19] mtd/st_smi: Avoid issuing multiple WE commands Vipin Kumar
2012-11-02 17:39   ` [U-Boot] [Drivers PATCH 04/19] mtd/st_smi: Write to flash in a tight loop Vipin Kumar
2012-11-02 17:39   ` [U-Boot] [Drivers PATCH 05/19] mtd/st_smi: Use page sizes respective to flash Vipin Kumar
2012-11-02 17:39   ` [U-Boot] [Drivers PATCH 06/19] usbh/ehci: Increase timeout for enumeration Vipin Kumar
2012-11-02 17:39   ` [U-Boot] [Drivers PATCH 07/19] sdhci: Add sdhci support for spear devices Vipin Kumar
2012-11-02 17:39   ` [U-Boot] [Drivers PATCH 08/19] net/designware: Do not select MIIPORT for RGMII interface Vipin Kumar
2012-11-02 17:39   ` [U-Boot] [Drivers PATCH 10/19] usb/gadget/designware_otg: Add support for designware otg Vipin Kumar
2012-11-02 17:39   ` [U-Boot] [Drivers PATCH 11/19] usb/host/ehci: Add support for EHCI on spear Vipin Kumar
2012-11-02 17:39   ` [U-Boot] [Drivers PATCH 12/19] usbtty: adapt buffers for large packet support Vipin Kumar
2012-11-02 17:39   ` [U-Boot] [Drivers PATCH 13/19] net/macb: Add arch specific routine to get mdio control Vipin Kumar
2012-11-02 17:39   ` [U-Boot] [Drivers PATCH 14/19] net/macb: workaround for transmission hang issue Vipin Kumar
2013-02-03 11:19     ` Albert ARIBAUD
2013-02-28 12:59       ` Albert ARIBAUD
2013-03-01  3:08         ` Bo Shen
2013-03-01  3:40           ` Vipin Kumar [this message]
2013-03-01  3:48             ` Bo Shen
2013-03-01  3:41         ` Vipin Kumar
2013-03-01  7:28           ` Albert ARIBAUD
2013-03-01  7:55             ` Vipin Kumar
2012-11-02 17:40   ` [U-Boot] [Drivers PATCH 15/19] misc/crypto: Add support for C3 Vipin Kumar
2012-11-02 17:40   ` [U-Boot] [Drivers PATCH 16/19] armv7/ltimer: Add support for local timer on armv7 cpus Vipin Kumar
2012-11-02 17:40   ` [U-Boot] [Drivers PATCH 17/19] imls: Add support to list images in NAND device Vipin Kumar
2012-11-06 23:30     ` Scott Wood
2012-11-07  5:15       ` Vipin Kumar
2012-11-07 20:49         ` Scott Wood
2012-11-02 17:40   ` [U-Boot] [Drivers PATCH 18/19] u-boot/spl: Add u-boot-spl.img to u-boot targets Vipin Kumar
2012-11-02 17:40   ` [U-Boot] [Drivers PATCH 19/19] arm/boards: Define a new config option CONFIG_BOOT_PARAMS_P Vipin Kumar
2012-11-02 17:39 ` [U-Boot] [SPEAr13xx PATCH 1/7] spear1340: Add support for spear1340 SoC Vipin Kumar
2012-11-02 17:39   ` [U-Boot] [SPEAr13xx PATCH 2/7] spear1310: Add support for spear1310 SoC Vipin Kumar
2012-11-02 17:39   ` [U-Boot] [SPEAr13xx PATCH 3/7] spear1340evb: Add support for evb machine Vipin Kumar
2012-11-02 17:39   ` [U-Boot] [SPEAr13xx PATCH 4/7] spear1310evb: " Vipin Kumar
2012-11-02 17:39   ` [U-Boot] [SPEAr13xx PATCH 5/7] spear1340lcad: Add support for LCAD machine Vipin Kumar
2012-11-02 17:39   ` [U-Boot] [SPEAr13xx PATCH 6/7] spear1340evb: Add SPL support Vipin Kumar
2012-11-02 17:39   ` [U-Boot] [SPEAr13xx PATCH 7/7] spear1310evb: " Vipin Kumar
2012-11-02 17:39 ` [U-Boot] [SPEAr Enhancement PATCH 1/9] spear: Add cache support Vipin Kumar
2012-11-02 17:39   ` [U-Boot] [SPEAr Enhancement PATCH 2/9] spear3xx: Add pinmux support Vipin Kumar
2012-11-02 17:39   ` [U-Boot] [SPEAr Enhancement PATCH 3/9] spear320plc: Correct the MACB interface Vipin Kumar
2012-11-02 17:39   ` [U-Boot] [SPEAr Enhancement PATCH 4/9] spear/configs: Modify several configurations Vipin Kumar
2012-11-02 17:39   ` [U-Boot] [SPEAr Enhancement PATCH 5/9] spear320: Add support for SD/MMC Vipin Kumar
2012-11-02 17:39   ` [U-Boot] [SPEAr Enhancement PATCH 6/9] spear320-hmi: Add support for hmi machine Vipin Kumar
2012-11-02 17:39   ` [U-Boot] [SPEAr Enhancement PATCH 7/9] spear6xx/spear3xx: Add support to boot via NAND device Vipin Kumar
2012-11-02 17:39   ` [U-Boot] [SPEAr Enhancement PATCH 8/9] spear/spl: Add support to boot from Parallel NOR device Vipin Kumar
2012-11-02 17:39   ` [U-Boot] [SPEAr Enhancement PATCH 9/9] spear300evb: Add SPL support Vipin Kumar
2012-11-02 17:39 ` [U-Boot] [SPEAr Fixes PATCH 01/11] SPEAr: Remove extra spear board configurations Vipin Kumar
2012-11-02 17:39   ` [U-Boot] [SPEAr Fixes PATCH 02/11] spear/configs: Split config files hierarchically into plat, arch, soc and board Vipin Kumar
2012-11-02 17:39   ` [U-Boot] [SPEAr Fixes PATCH 03/11] spear/include: Clean up the spear include files Vipin Kumar
2012-11-02 17:39   ` [U-Boot] [SPEAr Fixes PATCH 04/11] spear/board: Cleanup spear related board files Vipin Kumar
2012-11-02 17:39   ` [U-Boot] [SPEAr Fixes PATCH 05/11] spear: Append MISC_ as prefix to misc register bitmasks Vipin Kumar
2012-11-02 17:39   ` [U-Boot] [SPEAr Fixes PATCH 06/11] spear: Read ethaddr from I2C memory Vipin Kumar
2012-11-02 17:39   ` [U-Boot] [SPEAr Fixes PATCH 07/11] spear: Cleanup SoC area Vipin Kumar
2012-11-02 17:39   ` [U-Boot] [SPEAr Fixes PATCH 08/11] spear/spl: Cleanup spear SPL Vipin Kumar
2012-11-02 17:39   ` [U-Boot] [SPEAr Fixes PATCH 09/11] spear: Add POST memory support Vipin Kumar
2012-11-02 17:39   ` [U-Boot] [SPEAr Fixes PATCH 10/11] spear: Enable ehci support Vipin Kumar
2012-11-02 17:39   ` [U-Boot] [SPEAr Fixes PATCH 11/11] spear3xx: FIX: Enable access to memory for spear310 and spear320 Vipin Kumar
2012-11-07 14:10 ` [U-Boot] [PATCH 00/46] Enhance spear support Stefan Roese
2012-11-08  4:58   ` Vipin Kumar
2012-11-08  4:58   ` Vipin Kumar
     [not found]     ` <509CD19A.2060903@st.com>
2012-11-09 11:56       ` Stefan Roese
2012-11-10  8:48         ` Albert ARIBAUD
2012-11-11  6:11           ` Stefan Roese
2012-11-11  7:50             ` Wolfgang Denk
2012-11-11 17:49               ` Albert ARIBAUD
2012-11-12  9:34                 ` Armando Visconti
2012-11-12 10:35               ` Vipin Kumar
2012-11-21  9:24                 ` Wolfgang Denk
2012-11-30 11:15                   ` Armando Visconti
2012-11-30 12:34                     ` Wolfgang Denk
2012-11-30 14:10                       ` Armando Visconti
2012-12-03  5:51                       ` Vipin Kumar
2012-11-20  9:46 ` Vipin Kumar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5130232F.9000002@st.com \
    --to=vipin.kumar@st.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.