From mboxrd@z Thu Jan 1 00:00:00 1970 From: Juergen Gross Subject: Re: [PATCH] Rename credit2 names to csched2_* Date: Fri, 01 Mar 2013 07:06:02 +0100 Message-ID: <5130454A.9090802@ts.fujitsu.com> References: <550a413da1ac4333d4ec.1361967571@nehalem1> <512E0D9A02000078000C17E2@nat28.tlf.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <512E0D9A02000078000C17E2@nat28.tlf.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich Cc: xen-devel List-Id: xen-devel@lists.xenproject.org On 27.02.2013 13:43, Jan Beulich wrote: >>>> On 27.02.13 at 13:19, Juergen Gross wrote: >> Functions, variables, structures and macros in the credit2 scheduler had >> partially the same names as in the credit scheduler. This makes it hard to >> find the correct functions in backtraces or cscope. >> >> Rename all names in credit2 from csched_*/CSCHED_* to csched2_*/CSCHED2_* > > I don't think this is a suitable approach - if anything, we should aim > at having printed static symbols (in backtraces etc) prefixed with > their source file name. I would even question quite a few of the > csched_ prefixes in credit1... Just one other thought: unique names would help for analyzing crash dumps, too. Juergen -- Juergen Gross Principal Developer Operating Systems PBG PDG ES&S SWE OS6 Telephone: +49 (0) 89 3222 2967 Fujitsu Technology Solutions e-mail: juergen.gross@ts.fujitsu.com Domagkstr. 28 Internet: ts.fujitsu.com D-80807 Muenchen Company details: ts.fujitsu.com/imprint.html