From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rickard Andersson Subject: Re: [PATCH 3/4] ARM: nomadik: add dynamic irq flag to the timer Date: Fri, 1 Mar 2013 14:28:18 +0100 Message-ID: <5130ACF2.6070005@stericsson.com> References: <1361917047-29230-1-git-send-email-daniel.lezcano@linaro.org> <1361917047-29230-4-git-send-email-daniel.lezcano@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Linus Walleij Cc: Vincent Guittot , Daniel Lezcano , "john.stultz@linaro.org" , "tglx@linutronix.de" , "jacob.jun.pan@linux.intel.com" , Linus WALLEIJ , "linux-pm@vger.kernel.org" , "viresh.kumar@linaro.org" , "patches@linaro.org" , "linux-kernel@vger.kernel.org" , "linaro-kernel@lists.linaro.org" , "linux-arm-kernel@lists.infradead.org" List-Id: linux-pm@vger.kernel.org On 03/01/2013 09:56 AM, Vincent Guittot wrote: > On 1 March 2013 02:13, Linus Walleij wrote: >> On Tue, Feb 26, 2013 at 11:17 PM, Daniel Lezcano >> wrote: >> >>> Add the dynamic irq affinity feature to the timer clock device. >>> >>> Signed-off-by: Daniel Lezcano >> Looks reasonable to me, sadly I do not fully grasp the patch set, >> Vincent+Rickard can you have a look at this? > ux500 is able to trig the wake up on one CPU and let the other one in > WFI. This patch will minimize the spurious wake up of CPU0 when CPU1 > is the target CPU of the broadcast timer. One main consequence is that > we will not uselessly execute all the deferrable and newly idle > activities on the CPU0 . > > you can add my reviewed-by if you want > > Vincent > It looks ok to me as well. BR Rickard From mboxrd@z Thu Jan 1 00:00:00 1970 From: rickard.andersson@stericsson.com (Rickard Andersson) Date: Fri, 1 Mar 2013 14:28:18 +0100 Subject: [PATCH 3/4] ARM: nomadik: add dynamic irq flag to the timer In-Reply-To: References: <1361917047-29230-1-git-send-email-daniel.lezcano@linaro.org> <1361917047-29230-4-git-send-email-daniel.lezcano@linaro.org> Message-ID: <5130ACF2.6070005@stericsson.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 03/01/2013 09:56 AM, Vincent Guittot wrote: > On 1 March 2013 02:13, Linus Walleij wrote: >> On Tue, Feb 26, 2013 at 11:17 PM, Daniel Lezcano >> wrote: >> >>> Add the dynamic irq affinity feature to the timer clock device. >>> >>> Signed-off-by: Daniel Lezcano >> Looks reasonable to me, sadly I do not fully grasp the patch set, >> Vincent+Rickard can you have a look at this? > ux500 is able to trig the wake up on one CPU and let the other one in > WFI. This patch will minimize the spurious wake up of CPU0 when CPU1 > is the target CPU of the broadcast timer. One main consequence is that > we will not uselessly execute all the deferrable and newly idle > activities on the CPU0 . > > you can add my reviewed-by if you want > > Vincent > It looks ok to me as well. BR Rickard