From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oa0-f54.google.com ([209.85.219.54]) by linuxtogo.org with esmtp (Exim 4.72) (envelope-from ) id 1UBTeW-0003rq-Nn for openembedded-devel@lists.openembedded.org; Fri, 01 Mar 2013 18:21:53 +0100 Received: by mail-oa0-f54.google.com with SMTP id n12so6065091oag.13 for ; Fri, 01 Mar 2013 09:05:24 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-received:message-id:date:from:user-agent:mime-version:to:subject :references:in-reply-to:content-type:content-transfer-encoding :x-gm-message-state; bh=R3GJkFr8FiBRN29+wu+lfesBzkZsPwVhSJM3wHdrnsA=; b=HQ51EZfKZvvXP8jqnuKJqUCodjvyxUqmqkdlDllAPaNrnmVrN8uWBRXnf0vrnTG6q9 cmna4ATjcngy96vXeRkME5GTtrWDVbPpPiagJPvu0tG8ws43kCScoJZZEY8pdVzAlBcs YRvJddgSwtloFQc8ORl2Z43QxkWOoTi7xNu9zQKzYc1Kg8O0PReFv2XNhHkcf4EIXtrM AGnFqlkroxfW1Jd1knQnnIoWLv1VIVMfAKE8OVHqDaOIspoO2mXZt9HNNZuYOg4gm1E0 yy38sylq6qPkuK5Oe3eFKlo2Vpc271wpUL6u34gNPyEd/Sr8OqbdLk/dRRsYh8QTFzD+ 1dyg== X-Received: by 10.60.10.226 with SMTP id l2mr9224556oeb.67.1362157524539; Fri, 01 Mar 2013 09:05:24 -0800 (PST) Received: from [192.168.48.44] (wsip-70-183-20-162.oc.oc.cox.net. [70.183.20.162]) by mx.google.com with ESMTPS id w10sm18463702oed.2.2013.03.01.09.05.23 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 01 Mar 2013 09:05:23 -0800 (PST) Message-ID: <5130DFDA.6040907@felipetonello.com> Date: Fri, 01 Mar 2013 09:05:30 -0800 From: Felipe Ferreri Tonello User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/17.0 Thunderbird/17.0 MIME-Version: 1.0 To: openembedded-devel@lists.openembedded.org References: <1361995702-28964-1-git-send-email-ftonello@cercacor.com> <20130227203926.GE8208@jama.dyndns-home.com> <512E8A65.5070904@felipetonello.com> <20130228234746.GD3279@jama> In-Reply-To: <20130228234746.GD3279@jama> X-Gm-Message-State: ALoCoQloritAFmgxZ/sUa1YZjCyDrlx2EgEcl8avGlFZvkFSuUer/Ze3WW1OnJLS0ZQdCRV/zGWV Subject: Re: [meta-oe][PATCH] qextserialport: Added 1.2rc recipe X-BeenThere: openembedded-devel@lists.openembedded.org X-Mailman-Version: 2.1.11 Precedence: list Reply-To: openembedded-devel@lists.openembedded.org List-Id: Using the OpenEmbedded metadata to build Distributions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 01 Mar 2013 17:21:54 -0000 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Hi Martin, On 02/28/2013 03:47 PM, Martin Jansa wrote: > On Wed, Feb 27, 2013 at 02:36:21PM -0800, Felipe Ferreri Tonello wrote: >> Hi Martin, >> >> On 02/27/2013 12:39 PM, Martin Jansa wrote: >>> On Wed, Feb 27, 2013 at 12:08:21PM -0800, eu@felipetonello.com wrote: >>>> From: "Felipe F. Tonello" >>>> >>>> QExtSerialPort is a serial port library for Qt4/5. >>> >>> Is there good reason to redefine all those FILES_*? >>> >>> From previous mail: >>> It also has a lot of QA warnings, it's better to use += for FILES_, so >>> that default values are preserved where possible. >>> >> >> Ok. Got it. But in this case there is no more QA right. I know that I >> added the /usr/src/..., which is redundant, but still. If you want to me >> to remove, I can do it. > > QA warnings are still there > qextserialport-1.1+1.2rc: qextserialport: Files/directories were > installed but not shipped > /usr/src > /usr/src/debug > /usr/src/debug/qextserialport > /usr/src/debug/qextserialport/1.1+1.2rc-r0 > /usr/src/debug/qextserialport/1.1+1.2rc-r0/qextserialport-1.2rc > /usr/src/debug/qextserialport/1.1+1.2rc-r0/qextserialport-1.2rc/moc_qextserialport.cpp > /usr/src/debug/qextserialport/1.1+1.2rc-r0/qextserialport-1.2rc/moc_qextserialenumerator.cpp > /usr/src/debug/qextserialport/1.1+1.2rc-r0/qextserialport-1.2rc/src > /usr/src/debug/qextserialport/1.1+1.2rc-r0/qextserialport-1.2rc/src/qextserialport_unix.cpp > /usr/src/debug/qextserialport/1.1+1.2rc-r0/qextserialport-1.2rc/src/qextserialport_p.h > /usr/src/debug/qextserialport/1.1+1.2rc-r0/qextserialport-1.2rc/src/qextserialport.h > /usr/src/debug/qextserialport/1.1+1.2rc-r0/qextserialport-1.2rc/src/qextserialport.cpp > /usr/src/debug/qextserialport/1.1+1.2rc-r0/qextserialport-1.2rc/src/qextserialenumerator_p.h > /usr/src/debug/qextserialport/1.1+1.2rc-r0/qextserialport-1.2rc/src/qextserialenumerator_linux.cpp > /usr/src/debug/qextserialport/1.1+1.2rc-r0/qextserialport-1.2rc/src/qextserialenumerator.h > /usr/src/debug/qextserialport/1.1+1.2rc-r0/qextserialport-1.2rc/src/qextserialenumerator.cpp > > You added > /usr/src/debug/qextserialport-${PV}-${PR}/qextserialport-${REAL_PV} > but it's in > /usr/src/debug/qextserialport/${PV}-${PR}/qextserialport-${REAL_PV} \ > > But really use default FILES_ values and only add to it with += if > needed and only in some exceptions you have to overwrite it completely > (e.g. when foo.so from PN-dev is actually needed in PN). OK. Thanks, Felipe > >> >> At least, someone that takes this recipe knows exactly what's been >> installed. IMO the default FILES_ might be obscure to some new contributors. >> >> Thanks >> >> Felipe >> >>>> >>>> Signed-off-by: Felipe F. Tonello >>>> --- >>>> .../qextserialport/qextserialport_1.2rc.bb | 56 ++++++++++++++++++++ >>>> 1 file changed, 56 insertions(+) >>>> create mode 100644 meta-oe/recipes-qt/qextserialport/qextserialport_1.2rc.bb >>>> >>>> diff --git a/meta-oe/recipes-qt/qextserialport/qextserialport_1.2rc.bb b/meta-oe/recipes-qt/qextserialport/qextserialport_1.2rc.bb >>>> new file mode 100644 >>>> index 0000000..4cc9d6c >>>> --- /dev/null >>>> +++ b/meta-oe/recipes-qt/qextserialport/qextserialport_1.2rc.bb >>>> @@ -0,0 +1,56 @@ >>>> +DESCRIPTION = "Qt Ext Serial Port Library" >>>> +HOMEPAGE = "http://http://code.google.com/p/qextserialport/" >>>> +LICENSE = "MIT" >>>> +LIC_FILES_CHKSUM = "file://LICENSE;md5=b866a28cda707ec714878bd933f46251" >>>> +SECTION = "qt/libs" >>>> + >>>> +PR = "r0" >>>> + >>>> +# 1.2rc as version will sort lower then 1.2 when it's released >>>> +REAL_PV = "1.2rc" >>>> +PV = "1.1+${REAL_PV}" >>>> + >>>> +inherit qt4x11 pkgconfig >>>> + >>>> +DEPENDS = "udev" >>>> + >>>> +SRC_URI = " \ >>>> + http://qextserialport.googlecode.com/files/qextserialport-${REAL_PV}.zip \ >>>> +" >>>> + >>>> +SRC_URI[md5sum] = "ffa061edb9f64666468d18402eee6108" >>>> +SRC_URI[sha256sum] = "9cbee267aac9830f9944bb1d13872e51fba400aa9afe158e64f0fe265a0176bc" >>>> + >>>> +S = "${WORKDIR}/qextserialport-${REAL_PV}" >>>> + >>>> +FILES_${PN} = "${libdir}/libqextserialport${SOLIBS}" >>>> + >>>> +FILES_${PN}-dev = " \ >>>> + ${libdir}/libqextserialport${SOLIBSDEV} \ >>>> + ${libdir}/libqextserialport.prl \ >>>> + ${includedir}/QtExtSerialPort/*.h \ >>>> + ${datadir}/qt4/mkspecs/features/extserialport.prf \ >>>> +" >>>> + >>>> +FILES_${PN}-dbg = " \ >>>> + ${libdir}/.debug/libqextserialport.so* \ >>>> + /usr/src/debug/qextserialport-${PV}-${PR}/qextserialport-${REAL_PV} \ >>>> +" >>>> + >>>> +do_configure_prepend() { >>>> + # based on the documentation, this line make sure we use udev in linux >>>> + cd ${S} && echo "linux*:CONFIG += qesp_linux_udev" > .qmake.cache >>>> + >>>> + # Hacking hardcoded qmake variables >>>> + find *.pro -exec sed -i -e 's,$$\[QT_INSTALL_HEADERS\],${includedir},g' '{}' ';' >>>> + find *.pro -exec sed -i -e 's,$$\[QT_INSTALL_LIBS\],${libdir},g' '{}' ';' >>>> + find *.pro -exec sed -i -e 's,$$\[QMAKE_MKSPECS\],${datadir}/qt4/mkspecs/,g' '{}' ';' >>>> +} >>>> + >>>> +do_install() { >>>> + export INSTALL_ROOT=${D} >>>> + oe_runmake install >>>> + >>>> + # This is necessary to make it work with the qt based SDK >>>> + cd ${D}/${datadir}/qt4/mkspecs/features && sed -i -e "s|${STAGING_INCDIR_NATIVE}/qt4|\$(OE_QMAKE_INCDIR_QT)/..|" ./extserialport.prf >>>> +} >>>> -- >>>> 1.7.9.5 >> >> >> _______________________________________________ >> Openembedded-devel mailing list >> Openembedded-devel@lists.openembedded.org >> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel > > > > _______________________________________________ > Openembedded-devel mailing list > Openembedded-devel@lists.openembedded.org > http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel >