From: Eric Blake <eblake@redhat.com>
Cc: mdroth@linux.vnet.ibm.com, aliguori@us.ibm.com,
Lei Li <lilei@linux.vnet.ibm.com>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 2/2] qga: add guest-set-time command
Date: Fri, 01 Mar 2013 10:50:03 -0700 [thread overview]
Message-ID: <5130EA4B.4050504@redhat.com> (raw)
In-Reply-To: <5130E782.7080204@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 594 bytes --]
On 03/01/2013 10:38 AM, Eric Blake wrote:
>> + error_setg_errno(errp, errno, "Invalid time %ld for overflow",
>> + time_ns);
>
> That wording sounds awkward. Worse, errno is NOT set to anything sane,
> so you do NOT want error_setg_errno. And %ld is wrong for int64_t on
> 32-bit platforms. How about:
>
> error_setg(errp, "Time %" PRI64D " is too large", time_ns);
Don't know what I was thinking; there is no PRI64D. I meant PRId64.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 621 bytes --]
next prev parent reply other threads:[~2013-03-01 18:24 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-01 9:32 [Qemu-devel] [PATCH 0/2 v3] Time resync support by qemu-ga Lei Li
2013-03-01 9:32 ` [Qemu-devel] [PATCH 1/2] qga: add guest-get-time command Lei Li
2013-03-01 17:02 ` Eric Blake
2013-03-04 7:39 ` Lei Li
2013-03-01 9:33 ` [Qemu-devel] [PATCH 2/2] qga: add guest-set-time command Lei Li
2013-03-01 17:38 ` Eric Blake
2013-03-01 17:50 ` Eric Blake [this message]
2013-03-04 8:25 ` Lei Li
-- strict thread matches above, loose matches on Subject: below --
2013-03-04 9:16 [Qemu-devel] [PATCH 0/2 v4] Time resync support by qemu-ga Lei Li
2013-03-04 9:16 ` [Qemu-devel] [PATCH 2/2] qga: add guest-set-time command Lei Li
2013-03-04 18:16 ` mdroth
2013-03-04 19:03 ` Eric Blake
2013-03-04 19:01 ` Eric Blake
2013-03-05 9:39 [Qemu-devel] [PATCH 0/2 v5] Time resync support by qemu-ga Lei Li
2013-03-05 9:39 ` [Qemu-devel] [PATCH 2/2] qga: add guest-set-time command Lei Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5130EA4B.4050504@redhat.com \
--to=eblake@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=lilei@linux.vnet.ibm.com \
--cc=mdroth@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.