All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: Fengguang Wu <fengguang.wu@intel.com>
Cc: Felipe Balbi <balbi@ti.com>,
	Maarten Lankhorst <m.b.lankhorst@gmail.com>,
	linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [usb gadget] WARNING: at kernel/mutex.c:198 __mutex_lock_common()
Date: Sat, 02 Mar 2013 14:41:07 +0100	[thread overview]
Message-ID: <51320173.6000802@linutronix.de> (raw)
In-Reply-To: <20130302133736.GA13058@localhost>

On 03/02/2013 02:37 PM, Fengguang Wu wrote:
> On Wed, Feb 27, 2013 at 12:49:35PM +0200, Felipe Balbi wrote:
>> Hi,
>>
>> On Wed, Feb 06, 2013 at 10:04:24AM +0800, Fengguang Wu wrote:
>>> Greetings,
>>>
>>> I got the below warning and the first bad commit is
>>
>> can you send a fixup patch ?
> 
> Sorry I don't have the fix. Maarten once proposed
> 
> : Can you change __mutex_lock_common from inline to __always_inline and
> : check if that gets rid of the warning?
> 
> and it worked at that time, however it does not work today when I
> go out to double check the below patch...

This does not get even close to a fix, not to mention a proper one. The
problem is that a spinlock is hold while a mutex is going to be taken.
Maybe I get to this…

Sebastian

  reply	other threads:[~2013-03-02 13:41 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-06  2:04 [usb gadget] WARNING: at kernel/mutex.c:198 __mutex_lock_common() Fengguang Wu
2013-02-27 10:49 ` Felipe Balbi
2013-03-02 13:37   ` Fengguang Wu
2013-03-02 13:41     ` Sebastian Andrzej Siewior [this message]
2013-03-02 13:45       ` Fengguang Wu
2013-03-04 21:28 ` [PATCH] usb/gadget: initialize gadget functions helper befor functions & gadgets Sebastian Andrzej Siewior
2013-03-04 22:40   ` Michal Nazarewicz
2013-03-05  9:57   ` Fengguang Wu
2013-03-05 10:35     ` Fengguang Wu
2013-03-05 19:18       ` Sebastian Andrzej Siewior
2013-03-05 10:49   ` Felipe Balbi
2013-03-05 19:16     ` Sebastian Andrzej Siewior

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51320173.6000802@linutronix.de \
    --to=bigeasy@linutronix.de \
    --cc=balbi@ti.com \
    --cc=fengguang.wu@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=m.b.lankhorst@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.