From: Gabriele Mazzotta <gabriele.mzt@gmail.com>
To: alsa-devel@alsa-project.org
Subject: Re: [PATCH] ALSA: hda - Disable AA-loopback on ALC668
Date: Thu, 15 May 2014 21:56:23 +0200 [thread overview]
Message-ID: <5132959.uTC67tbQhF@xps13> (raw)
In-Reply-To: <1784940.JdFq8Pv96a@xps13>
On Wednesday 14 May 2014 16:31:13, Gabriele Mazzotta <gabriele.mzt@gmail.com> wrote:
> Disable the AA-loopback path to get rid of the constant white noise
> that can be heard when headphones are used.
>
> This patch was tested only on a Dell XPS13 9333.
>
> Fix based on d2e92709e88d ("ALSA: hda - Disable AA-loopback on ALC283
> Chromebook").
>
> Signed-off-by: Gabriele Mazzotta <gabriele.mzt@gmail.com>
> ---
> sound/pci/hda/patch_realtek.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
> index 5f7c765..21c94e4 100644
> --- a/sound/pci/hda/patch_realtek.c
> +++ b/sound/pci/hda/patch_realtek.c
> @@ -5690,6 +5690,13 @@ static int patch_alc662(struct hda_codec *codec)
> if (has_cdefine_beep(codec))
> spec->gen.beep_nid = 0x01;
>
> + switch (codec->vendor_id) {
> + case 0x10ec0668:
> + /* Disable AA-loopback as it causes white noise */
> + spec->gen.mixer_nid = 0;
> + break;
> + }
> +
> if ((alc_get_coef0(codec) & (1 << 14)) &&
> codec->bus->pci && codec->bus->pci->subsystem_vendor == 0x1025 &&
> spec->cdefine.platform_type == 1) {
>
I'm sorry, I was wrong. This patch does not help. I'm still trying to
understand what temporarily fixed the problem, I was quite sure this patch did
it, but all of the sudden the noise came back. I'm still trying to find the
real cause, but I doubt I'll succeed.
Regards,
Gabriele
next prev parent reply other threads:[~2014-05-15 19:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-14 14:31 [PATCH] ALSA: hda - Disable AA-loopback on ALC668 Gabriele Mazzotta
2014-05-15 19:56 ` Gabriele Mazzotta [this message]
2014-05-20 15:59 ` Gabriele Mazzotta
2014-05-20 16:06 ` Takashi Iwai
2014-05-20 16:15 ` Takashi Iwai
[not found] ` <7006803.45xCtKetRW@xps13>
2014-05-21 9:10 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5132959.uTC67tbQhF@xps13 \
--to=gabriele.mzt@gmail.com \
--cc=alsa-devel@alsa-project.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.