From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sylwester Nawrocki Subject: Re: [PATCH v6 01/16] clk: samsung: add common clock framework helper functions for Samsung platforms Date: Sun, 03 Mar 2013 12:17:29 +0100 Message-ID: <51333149.1060105@gmail.com> References: <1361175686-19400-1-git-send-email-thomas.abraham@linaro.org> <1361175686-19400-2-git-send-email-thomas.abraham@linaro.org> <201303030208.49722.heiko@sntech.de> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <201303030208.49722.heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Sender: "devicetree-discuss" To: =?UTF-8?B?SGVpa28gU3TDvGJuZXI=?= Cc: linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, mturquette-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org, devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, kgene.kim-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: linux-samsung-soc@vger.kernel.org SGksCgpPbiAwMy8wMy8yMDEzIDAyOjA4IEFNLCBIZWlrbyBTdMO8Ym5lciB3cm90ZToKPiBCdXQg aXMgdGhlcmUgYW4gZWFzeSB3YXkgdG8gZGVmaW5lIG1vcmUgdGhhbiBvbmUgYWxpYXM/IE9uIHRo ZSBzM2MyNDE2IGZvcgo+IGV4YW1wbGUgdGhlIGhzbW1jIGhjbGsgaXMgdGhlICJoc21tYyIgaW8t Y2xvY2ssIGFzIHdlbGwgYXMgdGhlIHNvdXJjZSBmb3IgdGhlCj4gIm1tY19idXNjbGsuMCIuIFNh bWUgZm9yIHRoZSAidWFydCIgcGNsaywgdGhhdCBpcyBhbHNvIGEgYmF1ZCBjbG9jayBzb3VyY2Uu CgpUaGlzIGRyaXZlciBjdXJyZW50bHkgcHJvdmlkZXMgZm9yIG9ubHkgb25lIGFkZGl0aW9uYWwg Y2xrZGV2IGxvb2t1cCBlbnRyeQpwZXIgYSBwbGF0Zm9ybSBjbG9jay4gSSBwb2ludGVkIG91dCB0 aGlzIGRlc2luZyBpc3N1ZSBpbiB0aGUgZWFybHkgdmVyc2lvbgpvZiB0aGUgcGF0Y2ggc2V0LiBJ dCdzIGJlY2F1c2UgYSBtYWNoaW5lIGNsb2NrIGRlZmluaXRpb24gaXMgY291cGxlZCB3aXRoCmEg Y2xvY2sgY29uc3VtZXIgZGVmaW5pdGlvbi4gQW5kIElNTyB2YXJpb3VzIHNhbXN1bmdfY2xvY2tf cmVnaXN0ZXJfKgpmdW5jdGlvbnMgc2hvdWxkIG5vdCBoYXZlIGNsa19yZWdpc3Rlcl9jbGtkZXYo KSBpbnNpZGUgdGhlbS4gSS5lLiBmaXJzdApzdGVwIGNvdWxkIGJlIHJlZ2lzdGVyaW5nIGFsbCBt YWNoaW5lIGNsb2NrcyBhbmQgaW4gdGhlIHNlY29uZCBvbmUgY2xrZGV2Cmxvb2t1cCBlbnRyaWVz IGNvdWxkIGJlIGNyZWF0ZWQuIFRoaXMgaXMgaG93IG1vc3QgKGFsbD8pIGV4aXN0aW5nIFNvQwpj bG9jayBkcml2ZXJzIGFyZSB3b3JraW5nLgoKQnV0IHRob3NlIG11bHRpcGxlIGFsaWFzZXMgYXJl IGltcG9ydGFudCBvbmx5IGZvciBtYWNoaW5lcyB3aXRoIGRldmljZQp0cmVlIHN1cHBvcnQsIGFy ZW4ndCB0aGV5ID8KCkkgaG9wZSB0aGlzIHBhdGNoIHNlcmllcyBnZXRzIG1lcmdlZCBlYXJseSB0 byBsaW51eC1uZXh0IGluIHRoZSAzLjEwCmN5Y2xlIHNvIHRoZSBtdWx0aXBsZSBhY2N1bXVsYXRl ZCBmaXh1cCBwYXRjaGVzIGZvciB0aGlzIGNsb2NrIGRyaXZlcgpjYW4gYmUgbWVyZ2VkIGFzIHdl bGwgYW5kIGlzc3VlcyBsaWtlIHRoYXQgeW91IHBvaW50ZWQgb3V0IGNhbiBiZQpyZXNvbHZlZCB3 aXRoIGluY3JlbWVudGFsIHBhdGNoZXMuCgpSZWdhcmRzLApTeWx3ZXN0ZXIKCgoKX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZGV2aWNldHJlZS1kaXNjdXNz IG1haWxpbmcgbGlzdApkZXZpY2V0cmVlLWRpc2N1c3NAbGlzdHMub3psYWJzLm9yZwpodHRwczov L2xpc3RzLm96bGFicy5vcmcvbGlzdGluZm8vZGV2aWNldHJlZS1kaXNjdXNzCg== From mboxrd@z Thu Jan 1 00:00:00 1970 From: sylvester.nawrocki@gmail.com (Sylwester Nawrocki) Date: Sun, 03 Mar 2013 12:17:29 +0100 Subject: [PATCH v6 01/16] clk: samsung: add common clock framework helper functions for Samsung platforms In-Reply-To: <201303030208.49722.heiko@sntech.de> References: <1361175686-19400-1-git-send-email-thomas.abraham@linaro.org> <1361175686-19400-2-git-send-email-thomas.abraham@linaro.org> <201303030208.49722.heiko@sntech.de> Message-ID: <51333149.1060105@gmail.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi, On 03/03/2013 02:08 AM, Heiko St?bner wrote: > But is there an easy way to define more than one alias? On the s3c2416 for > example the hsmmc hclk is the "hsmmc" io-clock, as well as the source for the > "mmc_busclk.0". Same for the "uart" pclk, that is also a baud clock source. This driver currently provides for only one additional clkdev lookup entry per a platform clock. I pointed out this desing issue in the early version of the patch set. It's because a machine clock definition is coupled with a clock consumer definition. And IMO various samsung_clock_register_* functions should not have clk_register_clkdev() inside them. I.e. first step could be registering all machine clocks and in the second one clkdev lookup entries could be created. This is how most (all?) existing SoC clock drivers are working. But those multiple aliases are important only for machines with device tree support, aren't they ? I hope this patch series gets merged early to linux-next in the 3.10 cycle so the multiple accumulated fixup patches for this clock driver can be merged as well and issues like that you pointed out can be resolved with incremental patches. Regards, Sylwester