All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tom Rini <trini@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v3 1/4] nand: Extend nand_(read|write)_skip_bad with *actual and limit parameters
Date: Sun, 3 Mar 2013 09:04:01 -0500	[thread overview]
Message-ID: <51335851.70009@ti.com> (raw)
In-Reply-To: <1362193150.30277.19@snotra>

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 03/01/2013 09:59 PM, Scott Wood wrote:
> On 03/01/2013 09:57:40 AM, Tom Rini wrote:
>> On Thu, Feb 28, 2013 at 07:37:51PM -0600, Scott Wood wrote:
>>>> + * @param lim        maximum size that length may be in
>>>> order to not + *            exceed the buffer
>>> 
>>> s/that length may be/that actual may be/
>> 
>> No?  We check that the requested length to something will fit
>> even if the caller doesn't care to know what actual is.
> 
> What I mean is that we're not saying "if (length > lim) error".
> We compute the actual, and if the actual exceeds "lim", then
> there's an error.

OK, I see your point.  My hang-up is that actual may be NULL.  So,
"maximum size that length may be once bad blocks are accounted for in
order to not exceed the buffer" ?

- -- 
Tom
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQIcBAEBAgAGBQJRM1hRAAoJENk4IS6UOR1WJ0oQAJdWo6WlggN3bbZ71XWDMqoi
+9Tn1lNbCVc/S4ez1NJiLr18bTrjDtY7Gvq3I0hwKkee//QAG0JTcibf2SRXJ7Wo
3ShfTdEwBuzq8mvIahTvlaSaFUCfu3oSaYGlz6Kq+bfAjlhN2s3ogjCOlqUbBT/7
GwKuue4LM3jhF8YPlF5hgssz1HAQdtt8QTTODcq4WZRisVn82W8uk4d9xSUb5Wrw
WdmrmD4v4lvtvXzimEUXyovlwvVFAX148hh1LIHKAl4pFLHaEDQF7YqtTqVgOrBR
A8ZEPYPTG/+xVhEmzxQPJsJxDhy5Z6Ax/hDyS8XVpP1qtd4V51k0ZV1pPl2UBnCI
5kyjy3oNAfQFrcP0XSeEYZaprSuy/0mC3gLbDV8kcNRYirCet124HhZU7qo7XWgO
0e1GwIKpp0a+somLE1QViGgzhsOKWhj7LL24n9jhC/aowFW365g7FIjEM9RK3mlY
v7Z/YW/9BLfd+qsvQp5VH3i8yA9QEoTCB/0O8kiLrogXoiYF37EdCn4wQLaIjiJO
uxk5Y3m+HuEOF7AZHYjvajH/WrkGg13TE70/BbPZRHOBnw89mtIwE/Ox4wJeIJ5T
Y3yoUNj59iAWXk8tr5PIBgbRpijc8DcrfLHInlDaVVrq5IdWubbCeNf9KNB+atYc
wRpDSFXnPkzT5WSus8Hf
=VPjG
-----END PGP SIGNATURE-----

  reply	other threads:[~2013-03-03 14:04 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-28 19:09 [U-Boot] [PATCH v3 0/4] Add NAND support to DFU, enable for am335x_evm Tom Rini
2013-02-28 19:09 ` [U-Boot] [PATCH v3 1/4] nand: Extend nand_(read|write)_skip_bad with *actual and limit parameters Tom Rini
2013-03-01  1:37   ` Scott Wood
2013-03-01 15:57     ` Tom Rini
2013-03-01 16:07       ` Tom Rini
2013-03-02  2:59       ` Scott Wood
2013-03-03 14:04         ` Tom Rini [this message]
2013-03-04 19:15           ` Scott Wood
2013-02-28 19:09 ` [U-Boot] [PATCH v3 2/4] dfu: NAND specific routines for DFU operation Tom Rini
2013-02-28 19:09 ` [U-Boot] [PATCH v3 3/4] am335x_evm: Add CONFIG_CMD_MTDPARTS and relevant defaults Tom Rini
2013-02-28 19:09 ` [U-Boot] [PATCH v3 4/4] am335x_evm: Enable DFU for NAND and MMC, provide example alt_info for both Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51335851.70009@ti.com \
    --to=trini@ti.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.