From: Jens Lehmann <Jens.Lehmann@web.de>
To: William Entriken <fulldecent@gmail.com>
Cc: git@vger.kernel.org, Phil Hord <hordp@cisco.com>,
Stefan Zager <szager@google.com>,
William Entriken <github.com@phor.net>,
Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH] submodule update: when using recursion, show full path
Date: Mon, 04 Mar 2013 01:06:08 +0100 [thread overview]
Message-ID: <5133E570.7030507@web.de> (raw)
In-Reply-To: <1362253499-48847-1-git-send-email-github.com@phor.net>
Am 02.03.2013 20:44, schrieb William Entriken:
> Previously when using update with recursion, only the path for the
> inner-most module was printed. Now the path is printed relative to
> the directory the command was started from. This now matches the
> behavior of submodule foreach.
>
> Signed-off-by: William Entriken <github.com@phor.net>
Thanks, this patch cleanly applies against maint and addresses all
issues from the previous rounds.
Acked-by: Jens Lehmann <Jens.Lehmann@web.de>
Junio, could you please squash in this additional test?
--------8<-------
diff --git a/t/t7406-submodule-update.sh b/t/t7406-submodule-update.sh
index feaec6c..70528b7 100755
--- a/t/t7406-submodule-update.sh
+++ b/t/t7406-submodule-update.sh
@@ -612,7 +612,8 @@ test_expect_success 'submodule update places git-dir in superprojects git-dir re
rm -rf super_update_r2 &&
git clone super_update_r super_update_r2 &&
(cd super_update_r2 &&
- git submodule update --init --recursive &&
+ git submodule update --init --recursive >actual &&
+ test_i18ngrep "Submodule path .submodule/subsubmodule.: checked out" actual &&
(cd submodule/subsubmodule &&
git log > ../../expected
) &&
next prev parent reply other threads:[~2013-03-04 0:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-22 4:25 [PATCH] submodule update: when using recursion, show full path Will Entriken
2013-02-22 19:17 ` Jens Lehmann
2013-03-02 19:44 ` William Entriken
2013-03-04 0:06 ` Jens Lehmann [this message]
2013-03-04 3:48 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5133E570.7030507@web.de \
--to=jens.lehmann@web.de \
--cc=fulldecent@gmail.com \
--cc=git@vger.kernel.org \
--cc=github.com@phor.net \
--cc=gitster@pobox.com \
--cc=hordp@cisco.com \
--cc=szager@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.