From: Randy Dunlap <rdunlap@infradead.org>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Nishanth Menon <nm@ti.com>,
Carlos Chinea <carlos.chinea@nokia.com>,
linux-omap@vger.kernel.org
Subject: Re: [PATCH resend] hsi: fix kernel-doc warnings
Date: Sun, 03 Mar 2013 18:58:08 -0800 [thread overview]
Message-ID: <51340DC0.8070708@infradead.org> (raw)
In-Reply-To: <CACRpkdb83GYi7FNjz-ZgbatTQzgZsB=PdkiCuVFt4TK1s2kM+g@mail.gmail.com>
On 03/03/13 18:56, Linus Walleij wrote:
> On Fri, Mar 1, 2013 at 8:11 PM, Randy Dunlap <rdunlap@infradead.org> wrote:
>
>> From: Randy Dunlap <rdunlap@infradead.org>
>>
>> Fix kernel-doc warnings in hsi files:
>>
>> Warning(include/linux/hsi/hsi.h:136): Excess struct/union/enum/typedef member 'e_handler' description in 'hsi_client'
>> Warning(include/linux/hsi/hsi.h:136): Excess struct/union/enum/typedef member 'pclaimed' description in 'hsi_client'
>> Warning(include/linux/hsi/hsi.h:136): Excess struct/union/enum/typedef member 'nb' description in 'hsi_client'
>> Warning(drivers/hsi/hsi.c:434): No description found for parameter 'handler'
>> Warning(drivers/hsi/hsi.c:434): Excess function parameter 'cb' description in 'hsi_register_port_event'
>>
>> Don't document "private:" fields with kernel-doc notation.
>> If you want to leave them fully documented, that's OK, but
>> then don't mark them as "private:".
>>
>> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
>> Cc: Carlos Chinea <carlos.chinea@nokia.com>
>> Cc: Linus Walleij <linus.walleij@linaro.org>
>> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>> Cc: linux-kernel@vger.kernel.org
>> Cc: linux-omap@vger.kernel.org
>> Acked-by: Nishanth Menon <nm@ti.com>
>
> Acked-by: Linus Walleij <linus.walleij@linaro.org>
>
> HSI is basically orphaned FTM.
>
> Andrew can you pick this into your orphanage?
Linus (Torvalds) already merged it. Thanks.
--
~Randy
prev parent reply other threads:[~2013-03-04 2:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-01 19:11 [PATCH resend] hsi: fix kernel-doc warnings Randy Dunlap
2013-03-04 2:56 ` Linus Walleij
2013-03-04 2:58 ` Randy Dunlap [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51340DC0.8070708@infradead.org \
--to=rdunlap@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=carlos.chinea@nokia.com \
--cc=gregkh@linuxfoundation.org \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=nm@ti.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.