From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:43586) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UCSVS-0004ZV-Hw for qemu-devel@nongnu.org; Mon, 04 Mar 2013 05:20:31 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UCSVR-00019y-7x for qemu-devel@nongnu.org; Mon, 04 Mar 2013 05:20:30 -0500 Received: from mel.act-europe.fr ([194.98.77.210]:46237) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UCSEv-0001bi-Aw for qemu-devel@nongnu.org; Mon, 04 Mar 2013 05:03:25 -0500 Message-ID: <5134716C.9020001@adacore.com> Date: Mon, 04 Mar 2013 11:03:24 +0100 From: Fabien Chouteau MIME-Version: 1.0 References: <1362158507-19310-1-git-send-email-chouteau@adacore.com> <1362158507-19310-4-git-send-email-chouteau@adacore.com> <201303012051.17503.paul@codesourcery.com> In-Reply-To: <201303012051.17503.paul@codesourcery.com> Content-Type: text/plain; charset=ISO-8859-6 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 3/4] target-arm: Fix VFP register byte order in GDB remote List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paul Brook Cc: peter.maydell@linaro.org, qemu-devel@nongnu.org, afaerber@suse.de On 03/01/2013 09:51 PM, Paul Brook wrote: >> From GDB Remote Serial Protocol doc: >> >> "The bytes with the register are transmitted in target byte order." > >> /* Aliases for Q regs. */ >> nregs += 16; >> if (reg < nregs) { >> >> - stfq_le_p(buf, env->vfp.regs[(reg - 32) * 2]); >> - stfq_le_p(buf + 8, env->vfp.regs[(reg - 32) * 2 + 1]); >> + stfq_p(buf, env->vfp.regs[(reg - 32) * 2]); >> + stfq_p(buf + 8, env->vfp.regs[(reg - 32) * 2 + 1]); > > This is wrong. You're still using little-endian ordering of words. > Can you explain a little bit further? If I'm in big-endian mode, stfq_p() will be stfq_be_p(), right? Thanks, -- Fabien Chouteau