From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:46114) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UCSf8-0002vE-Ru for qemu-devel@nongnu.org; Mon, 04 Mar 2013 05:30:35 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UCSf7-0004KF-HP for qemu-devel@nongnu.org; Mon, 04 Mar 2013 05:30:30 -0500 Received: from mel.act-europe.fr ([194.98.77.210]:33143) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UCSf7-0004Ju-AE for qemu-devel@nongnu.org; Mon, 04 Mar 2013 05:30:29 -0500 Message-ID: <513477C1.5080505@adacore.com> Date: Mon, 04 Mar 2013 11:30:25 +0100 From: Fabien Chouteau MIME-Version: 1.0 References: <1362158507-19310-1-git-send-email-chouteau@adacore.com> <1362158507-19310-5-git-send-email-chouteau@adacore.com> <201303012058.26277.paul@codesourcery.com> In-Reply-To: <201303012058.26277.paul@codesourcery.com> Content-Type: text/plain; charset=ISO-8859-6 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 4/4] target-arm: always set endian bits in big-endian mode List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paul Brook Cc: peter.maydell@linaro.org, qemu-devel@nongnu.org, afaerber@suse.de On 03/01/2013 09:58 PM, Paul Brook wrote: >> +#ifdef TARGET_WORDS_BIGENDIAN >> + if (arm_feature(env, ARM_FEATURE_V6) >> + || arm_feature(env, ARM_FEATURE_V7)) { >> + /* IE and EE bits stay set for big-endian */ >> + env->cp15.c1_sys |= (1 << 31) | (1 << 25); >> + } >> +#endif > > This is wrong for all the CPUs QEMU crrently supports. SCTLR.IE is defined to > be zero. > Again I'd like to have more information. Why is it wrong to set IE when we are in big-endian? Thanks, -- Fabien Chouteau