From: Daniel Mack <zonque@gmail.com>
To: Yegor Yefremov <yegorslists@googlemail.com>
Cc: "Porter, Matt" <mporter@ti.com>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
Vaibhav Bedia <vaibhav.bedia@ti.com>
Subject: Re: [PATCH v4 2/2] ALSA: ASoC: davinci-mcasp: don't overwrite DIT settings
Date: Mon, 04 Mar 2013 12:02:10 +0100 [thread overview]
Message-ID: <51347F32.2020809@gmail.com> (raw)
In-Reply-To: <CAGm1_kvHNVA9AjJSJdG001k=TLoKE=c1MahuWPb44+udPBf+yw@mail.gmail.com>
On 04.03.2013 11:58, Yegor Yefremov wrote:
> On Mon, Mar 4, 2013 at 11:43 AM, Daniel Mack <zonque@gmail.com> wrote:
>> On 04.03.2013 11:34, yegorslists@googlemail.com wrote:
>>> From: Yegor Yefremov <yegorslists@googlemail.com>
>>>
>>> Channel size settings will be made at the end of
>>> davinci_mcasp_hw_params() routine and thus overwrite frame
>>> format settings made for DIT mode. This patch fixes this issue
>>> by taking op_mode into account. Tested with official PSP 3.2
>>> kernel and sii9022a HDMI transmitter.
>>>
>>> Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>
>>
>> For both, wrt a survived regression test :)
>>
>> Tested-by: Daniel Mack <zonque@gmail.com>
>
> Thanks.
>
> How do you make the test? Is it "doesn't break compilation" test? Or
> do you have S/PDIF capable device?
No, I'm running the driver in IIS mode, with a codec attached to the I2S
lines. All I can do for now is test that your patches do not break my
environment. I can not test DIT.
Daniel
next prev parent reply other threads:[~2013-03-04 11:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-04 10:34 [PATCH v4 1/2] ALSA: ASoC: davinci-mcasp: don't configure AFSX direction in DIT mode yegorslists
2013-03-04 10:34 ` [PATCH v4 2/2] ALSA: ASoC: davinci-mcasp: don't overwrite DIT settings yegorslists
2013-03-04 10:43 ` Daniel Mack
2013-03-04 10:58 ` Yegor Yefremov
2013-03-04 11:02 ` Daniel Mack [this message]
2013-03-04 11:09 ` Yegor Yefremov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51347F32.2020809@gmail.com \
--to=zonque@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=mporter@ti.com \
--cc=vaibhav.bedia@ti.com \
--cc=yegorslists@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.