From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= Subject: Re: [Qemu-devel] [PATCH v7 03/11] target-arm: Drop CPUARMState* argument from bank_number() Date: Mon, 04 Mar 2013 12:12:05 +0100 Message-ID: <51348185.6040805@suse.de> References: <1361900421-28354-1-git-send-email-peter.maydell@linaro.org> <1361900421-28354-4-git-send-email-peter.maydell@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: qemu-devel@nongnu.org, Gleb Natapov , kvm@vger.kernel.org, patches@linaro.org, Marcelo Tosatti , kvmarm@lists.cs.columbia.edu, Blue Swirl , Paolo Bonzini To: Peter Maydell Return-path: Received: from cantor2.suse.de ([195.135.220.15]:38694 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756919Ab3CDLMH (ORCPT ); Mon, 4 Mar 2013 06:12:07 -0500 In-Reply-To: <1361900421-28354-4-git-send-email-peter.maydell@linaro.org> Sender: kvm-owner@vger.kernel.org List-ID: Am 26.02.2013 18:40, schrieb Peter Maydell: > Drop the CPUARMState* argument from bank_number(), since we only > use it for passing to cpu_abort(). Use hw_error() instead. > This avoids propagating further interfaces using env pointers. >=20 > In the long term this function's callers need auditing to fix > problems where badly behaved guests can pass invalid bank numbers. >=20 > Signed-off-by: Peter Maydell Reviewed-by: Andreas F=E4rber Thanks, Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrn= berg From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:56364) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UCTJQ-0003pk-RQ for qemu-devel@nongnu.org; Mon, 04 Mar 2013 06:12:10 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UCTJP-0007u0-Mp for qemu-devel@nongnu.org; Mon, 04 Mar 2013 06:12:08 -0500 Received: from cantor2.suse.de ([195.135.220.15]:38696 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UCTJP-0007ts-HF for qemu-devel@nongnu.org; Mon, 04 Mar 2013 06:12:07 -0500 Message-ID: <51348185.6040805@suse.de> Date: Mon, 04 Mar 2013 12:12:05 +0100 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1361900421-28354-1-git-send-email-peter.maydell@linaro.org> <1361900421-28354-4-git-send-email-peter.maydell@linaro.org> In-Reply-To: <1361900421-28354-4-git-send-email-peter.maydell@linaro.org> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v7 03/11] target-arm: Drop CPUARMState* argument from bank_number() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: kvm@vger.kernel.org, Gleb Natapov , patches@linaro.org, Marcelo Tosatti , qemu-devel@nongnu.org, Blue Swirl , Paolo Bonzini , kvmarm@lists.cs.columbia.edu Am 26.02.2013 18:40, schrieb Peter Maydell: > Drop the CPUARMState* argument from bank_number(), since we only > use it for passing to cpu_abort(). Use hw_error() instead. > This avoids propagating further interfaces using env pointers. >=20 > In the long term this function's callers need auditing to fix > problems where badly behaved guests can pass invalid bank numbers. >=20 > Signed-off-by: Peter Maydell Reviewed-by: Andreas F=E4rber Thanks, Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg