Re: [PATCH v1 0/12] libxl: new hotplug calling convention

["Roger Pau Monné" <roger.pau@citrix.com>]

On 23/01/13 18:48, Roger Pau Monne wrote:
> This series implements a new hoplug calling convention for libxl.
> 
> The aim of this new convention is to reduce the blackout phase of 
> migration when using complex hotplug scripts, like iSCSI or other kind 
> of storage backends that might have a non trivial setup time.
> 
> There are some issues that I would like to discuss, the first one is 
> the fact that pdev_path field in libxl_device_disk is no longuer used 
> to store a physical path, since diskspec "target" can now contain 
> "random" information to connect a block device. This is not a blocker 
> for this series to be accepted, but I'm tempted to say that the easier 
> way to solve this is to use a union for target and pdev_path, this 
> way everything will work as expected, and semantics will be right.
> 
> The second issue is related to iSCSI and iscsiadm, specifically the 
> way to set authentication parameters, which is done with command line 
> parameters or editing files (which each distro seems to place in 
> different locations). I will look into this to see if we can find a 
> suitable solution.
> 
> Thanks for the comments, Roger.
> 
> Branch available in the git repository at:
>   git://xenbits.xen.org/people/royger/xen.git iscsi_v1
> 
> *Acked
> 
> Roger Pau Monne (12):
>      *libxl: libxl__prepare_ao_device should reset num_exec
>       libxl: remove double check in NetBSD hotplug
>       libxl: move libxl_device_action to idl
>       libxl: pack hotplug related variables
>       libxl: add new hotplug interface support to hotplug script callers
>       libxl: add support for different hotplug interfaces
>       libxl: add prepare/unprepare operations to the libxl public interface
>       libxl: add disk specific remove functions
>       xl: add support for new hotplug interface to block-attach/detach
>       libxl: add local attach support for new hotplug scripts
>       hotplug: document new hotplug interface
>       hotplug/Linux: add iscsi block hotplug script
> 
>  docs/misc/libxl-hotplug-interface.txt |  167 +++++++++++++++++
>  tools/hotplug/Linux/Makefile          |    1 +
>  tools/hotplug/Linux/block-iscsi       |  258 +++++++++++++++++++++++++
>  tools/libxl/libxl.c                   |  332 +++++++++++++++++++++++++++++----
>  tools/libxl/libxl.h                   |    8 +
>  tools/libxl/libxl_bootloader.c        |    1 +
>  tools/libxl/libxl_create.c            |   62 ++++++-
>  tools/libxl/libxl_device.c            |  153 +++++++++++++---
>  tools/libxl/libxl_internal.h          |   87 ++++++++-
>  tools/libxl/libxl_linux.c             |   78 ++++++---
>  tools/libxl/libxl_netbsd.c            |   10 +-
>  tools/libxl/libxl_types.idl           |    1 +
>  tools/libxl/libxl_types_internal.idl  |   10 +
>  tools/libxl/xl_cmdimpl.c              |    5 +
>  14 files changed, 1071 insertions(+), 102 deletions(-)
>  create mode 100644 docs/misc/libxl-hotplug-interface.txt
>  create mode 100644 tools/hotplug/Linux/block-iscsi

It has been some time since I've posted the series, should I rebase and
resend them?