From: "Bryn M. Reeves" <bmr@redhat.com>
To: device-mapper development <dm-devel@redhat.com>
Subject: Re: Chicken and egg problem with multipath-tools
Date: Mon, 04 Mar 2013 11:27:52 +0000 [thread overview]
Message-ID: <51348538.20406@redhat.com> (raw)
In-Reply-To: <513481CF.8020405@suse.de>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 03/04/2013 11:13 AM, Hannes Reinecke wrote:
> multipathd/main.c:1996 /* Startup complete, create logfile */
> pid_rc = pidfile_create(DEFAULT_PIDFILE, daemon_pid); /* Ignore
> errors, we can live without */
>
>
> No option, but multipathd doesn't _need_ to create a pidfile. And
> it certainly won't abort if it cannot create one.
Maybe an old version (prior to commit 6cda789 in May 2011)?
- - if (pidfile_create(DEFAULT_PIDFILE, getpid())) {
- - if (logsink)
- - log_thread_stop();
+ if (pidfile_create(DEFAULT_PIDFILE, getpid()))
+ /* Ignore errors, we can live without */
+ condlog(1, "failed to create pidfile");
- - exit(1);
- - }
If this is the case then using a more recent multipath-tools would
definitely be a good plan.
Regards,
Bryn.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
iEYEARECAAYFAlE0hTgACgkQ6YSQoMYUY96+8wCdG/zOh6fDAOW2LzCNitHNTiek
VzkAn3ovG1230AQMPV/uRcVk8pA1emN/
=o2M/
-----END PGP SIGNATURE-----
next prev parent reply other threads:[~2013-03-04 11:27 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-02 10:43 Chicken and egg problem with multipath-tools Andrei B.
2013-03-03 11:42 ` Gabriel de Perthuis
2013-03-03 21:01 ` Andrei B
2013-03-04 10:49 ` Bryn M. Reeves
2013-03-04 6:54 ` Hannes Reinecke
2013-03-04 11:00 ` Andrei B.
2013-03-04 11:13 ` Hannes Reinecke
2013-03-04 11:27 ` Bryn M. Reeves [this message]
2013-03-04 10:54 ` Bryn M. Reeves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51348538.20406@redhat.com \
--to=bmr@redhat.com \
--cc=dm-devel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.