Re: [PATCH] ARM: S5PV210: Fix compilation error in mach-goni.c

[Sylwester Nawrocki <s.nawrocki@samsung.com>]

On 03/04/2013 02:11 PM, Kukjin Kim wrote:
> Sachin Kamat wrote:
>> On 25 February 2013 15:34, Sylwester Nawrocki <s.nawrocki@samsung.com>
>> wrote:
>>> On 02/25/2013 09:12 AM, Sachin Kamat wrote:
>>>> Commit 56bc91 ("[media] s5p-fimc: Redefine platform data structure for
>> fimc-is")
>>>> split bus_type into fimc_bus_type and sensor_bus_type and converted all
>>>> instances of it. This file however escaped the change.
>>>>
>>>> Without this patch we get the following build error:
>>>> arch/arm/mach-s5pv210/mach-goni.c:848:3: error:
>>>> unknown field 'bus_type' specified in initializer
>>>>
>>>> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
>>>> Cc: Sylwester Nawrocki <s.nawrocki@samsung.com>
>>>
>>> Thanks for the patch. My apologies for this omission, there is already
>>> similar patch from Arnd [1], [2].
>>
>> Yes, they fix the same issue. I had not noticed them earlier.
>>
> So, when can be fixed?

Could you apply patch from Arnd: "[PATCH 8/9] s5p-fimc: fix s5pv210 build"
or teh $subject patch from Sachin ? It may take long time to push the fix
through the media tree, as Mauro sends bug fixes to Linus usually only
twice per whole -rc cycle. And now the issue is only at arch/arm, hence
the arm-soc tree may be more appropriate.

My apologies for overlooking this, I'll be more careful next time.

> arch/arm/mach-s5pv210/mach-goni.c:848:3: error: unknown field 'bus_type'
> specified in initializer
>   CC      arch/arm/mm/idmap.o
> make[2]: *** [arch/arm/mach-s5pv210/mach-goni.o] Error 1
> make[2]: *** Waiting for unfinished jobs....
> 
> - Kukjin

Regards,
Sylwester