From mboxrd@z Thu Jan  1 00:00:00 1970
From: Zoltan Kiss <zoltan.kiss@citrix.com>
Subject: [blkback] blkback statistic counters are signed values
Date: Mon, 4 Mar 2013 15:54:42 +0000
Message-ID: <5134C3C2.6040108@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
List-Id: xen-devel@lists.xenproject.org

Hi,

One of our colleagues spotted a problem in xentop. Sometimes the 
VBD_WSECT value suddenly becomes unreasonably high, and it turned out 
xentop reads 
/sys/bus/xen-backend/devices/vbd-(domid)-(devID)/statistics/wr_sect into 
an unsigned long long. That value is exposed by blkback, and among other 
stat counters, it's a signed integer:

drivers/block/xen-blkback/common.h
struct xen_blkif {
...
	int			st_rd_req;
	int			st_wr_req;
	int			st_oo_req;
	int			st_f_req;
	int			st_ds_req;
	int			st_rd_sect;
	int			st_wr_sect;


I don't think these values should be negative ever, but when they 
overflow (which happens eventually), they do, and this leads to bad 
conversion in xentop.
I think the best solution would be to change the above mentioned values 
to unsigned long long as well. Any comments on that?

Regards,

Zoltan Kiss