From: Jon Hunter <jon-hunter@ti.com>
To: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
Cc: Grant Likely <grant.likely@secretlab.ca>,
Rob Landley <rob@landley.net>, Benoit Cousson <b-cousson@ti.com>,
Stephen Warren <swarren@nvidia.com>,
devicetree-discuss@lists.ozlabs.org,
linux-omap <linux-omap@vger.kernel.org>
Subject: Re: [PATCH 1/1] gpio: omap: dts: Move interrupt-controller from #interrupt-cells description
Date: Mon, 4 Mar 2013 13:23:52 -0600 [thread overview]
Message-ID: <5134F4C8.4010003@ti.com> (raw)
In-Reply-To: <1362422157-32196-1-git-send-email-javier.martinez@collabora.co.uk>
On 03/04/2013 12:35 PM, Javier Martinez Canillas wrote:
> The binding documentation for the OMAP GPIO controller has the description
> for the "#interrupt-cells" property after the "interrupt-controller"
> definition. This is confusing so is better to move "interrupt-controller"
> after the "#interrupt-cells" description.
>
> Reported-by: Stephen Warren <swarren@nvidia.com>
> Signed-off-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
> ---
> .../devicetree/bindings/gpio/gpio-omap.txt | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/gpio/gpio-omap.txt b/Documentation/devicetree/bindings/gpio/gpio-omap.txt
> index bff51a2..8b9914c 100644
> --- a/Documentation/devicetree/bindings/gpio/gpio-omap.txt
> +++ b/Documentation/devicetree/bindings/gpio/gpio-omap.txt
> @@ -10,7 +10,6 @@ Required properties:
> - second cell is used to specify optional parameters (unused)
> - gpio-controller : Marks the device node as a GPIO controller.
> - #interrupt-cells : Should be 2.
> -- interrupt-controller: Mark the device node as an interrupt controller
> The first cell is the GPIO number.
> The second cell is used to specify flags:
> bits[3:0] trigger type and level flags:
> @@ -18,6 +17,7 @@ Required properties:
> 2 = high-to-low edge triggered.
> 4 = active high level-sensitive.
> 8 = active low level-sensitive.
> +- interrupt-controller: Mark the device node as an interrupt controller.
>
> OMAP specific properties:
> - ti,hwmods: Name of the hwmod associated to the GPIO:
>
Thanks. Do you mind putting "interrupt-controller" before
"#interrupt-cells" as I see this is how they have it in
Documenation/devicetree/bindings/interrupt-controller/interrupts.txt?
Otherwise ...
Acked-by: Jon Hunter <jon-hunter@ti.com>
Cheers
Jon
next prev parent reply other threads:[~2013-03-04 19:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-04 18:35 [PATCH 1/1] gpio: omap: dts: Move interrupt-controller from #interrupt-cells description Javier Martinez Canillas
2013-03-04 19:23 ` Jon Hunter [this message]
2013-03-04 20:44 ` Javier Martinez Canillas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5134F4C8.4010003@ti.com \
--to=jon-hunter@ti.com \
--cc=b-cousson@ti.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=grant.likely@secretlab.ca \
--cc=javier.martinez@collabora.co.uk \
--cc=linux-omap@vger.kernel.org \
--cc=rob@landley.net \
--cc=swarren@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.