From: Alex Elder <elder@inktank.com>
To: Gregory Farnum <greg@inktank.com>
Cc: "ceph-devel@vger.kernel.org" <ceph-devel@vger.kernel.org>
Subject: Re: [PATCH 1/3] libceph: drop mutex while allocating a message
Date: Mon, 04 Mar 2013 13:25:46 -0600 [thread overview]
Message-ID: <5134F53A.1010601@inktank.com> (raw)
In-Reply-To: <CAPYLRzhQeqbEK6wp+V8OWaAeyML1Uqh60vc0omanTyvCsXtTXQ@mail.gmail.com>
On 03/04/2013 01:07 PM, Gregory Farnum wrote:
> On Mon, Mar 4, 2013 at 10:12 AM, Alex Elder <elder@inktank.com> wrote:
>> In ceph_con_in_msg_alloc(), if no alloc_msg method is defined for a
>> connection a new message is allocated with ceph_msg_new().
>>
>> Drop the mutex before making this call, and make sure we're still
>> connected when we get it back again.
>
> Why do we need to drop the mutex at all? The mds_alloc_msg() that
> you're about to define doesn't seem to need it.
> -Greg
>
My purpose in doing this is to make the third patch in
this series trivial to review. That is, I make the code
here match what will happen when I unify how all alloc_msg
calls get made, as a pre-step, and then it's easier to see
that the later patch is correct.
I agree, it's not needed for that allocator. By the same
token, it almost certainly causes no harm, and the end result
will be consistent handling by all users of this interface.
-Alex
next prev parent reply other threads:[~2013-03-04 19:25 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-04 18:05 OSD Data Read/Write Separation Patches Alex Elder
2013-03-04 18:08 ` [PATCH 0/3] libceph: a few cleanups Alex Elder
2013-03-04 18:09 ` [PATCH 1/3] libceph: use (void *) for untyped data in osd ops Alex Elder
2013-03-04 18:09 ` [PATCH 2/3] libceph: kill ceph_msg->pagelist_count Alex Elder
2013-03-04 18:09 ` [PATCH 3/3] libceph: rename ceph_calc_object_layout() Alex Elder
2013-03-05 1:49 ` [PATCH 0/3] libceph: a few cleanups Josh Durgin
2013-03-04 18:10 ` [PATCH 0/3] libceph: simplify incoming message allocation Alex Elder
2013-03-04 18:12 ` [PATCH 1/3] libceph: drop mutex while allocating a message Alex Elder
2013-03-04 19:07 ` Gregory Farnum
2013-03-04 19:25 ` Alex Elder [this message]
2013-03-04 19:39 ` Gregory Farnum
2013-03-04 19:52 ` Alex Elder
2013-03-04 18:12 ` [PATCH 2/3] libceph: define mds_alloc_msg() method Alex Elder
2013-03-04 19:05 ` Gregory Farnum
2013-03-04 19:37 ` Alex Elder
2013-03-04 18:12 ` [PATCH 3/3] libceph: no need for alignment for mds message Alex Elder
2013-03-04 19:09 ` Gregory Farnum
2013-03-04 18:14 ` [PATCH 0/3] ceph: assign message data fields consistently Alex Elder
2013-03-04 18:15 ` [PATCH 1/3] ceph: use calc_pages_for() in start_read() Alex Elder
2013-03-04 18:15 ` [PATCH 2/3] ceph: simplify ceph_sync_write() page_align calculation Alex Elder
2013-03-04 18:15 ` [PATCH 3/3] libceph: don't assign page info in ceph_osdc_new_request() Alex Elder
2013-03-05 1:55 ` [PATCH 0/3] ceph: assign message data fields consistently Josh Durgin
2013-03-04 18:16 ` [PATCH 0/3] libceph: distinguish osd request read and write data Alex Elder
2013-03-04 18:17 ` [PATCH 1/3] libceph: separate osd request data info Alex Elder
2013-03-05 2:13 ` Josh Durgin
2013-03-04 18:18 ` [PATCH 2/3] libceph: distinguish page and bio requests Alex Elder
2013-03-05 2:14 ` Josh Durgin
2013-03-04 18:18 ` [PATCH 3/3] libceph: separate read and write data Alex Elder
2013-03-05 2:15 ` Josh Durgin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5134F53A.1010601@inktank.com \
--to=elder@inktank.com \
--cc=ceph-devel@vger.kernel.org \
--cc=greg@inktank.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.