From: Bo Shen <voice.shen@atmel.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 4/4] ARM: atmel: add sama5d3xek support
Date: Tue, 05 Mar 2013 10:23:22 +0800 [thread overview]
Message-ID: <5135571A.5060700@atmel.com> (raw)
In-Reply-To: <20130305022015.GC16106@bill-the-cat>
Hi Tom,
Thanks.
On 3/5/2013 10:20, Tom Rini wrote:
> On Tue, Mar 05, 2013 at 10:03:57AM +0800, Bo Shen wrote:
>> Hi Tom,
>>
>> On 3/4/2013 23:14, Tom Rini wrote:
>>> On Thu, Feb 28, 2013 at 03:00:47PM +0800, Bo Shen wrote:
> [snip]
>>>> @@ -0,0 +1,268 @@
>>>> +/*
>>>> + * Configuation settings for the SAMA5D3xEK board.
>>> [snip]
>>>> +#undef CONFIG_USE_IRQ /* we don't need IRQ/FIQ stuff */
>>>> +
>>>> +#undef CONFIG_CMDLINE_TAG /* enable passing of ATAGs */
>>>> +#undef CONFIG_SETUP_MEMORY_TAGS
>>>> +#undef CONFIG_INITRD_TAG
>>>
>>> Just leave these, and the other #undef's out.
>>
>> You mean I need not to #undef these, because these are not defined,
>> am I right?
>
> Correct.
OK, I will remove it next version.
>>
>>>> +/*
>>>> + * Command line configuration.
>>>> + */
>>>> +#include <config_cmd_default.h>
>>>> +#undef CONFIG_CMD_FPGA
>>>> +#undef CONFIG_CMD_IMI
>>>> +#undef CONFIG_CMD_IMLS
>>>> +#undef CONFIG_CMD_AUTOSCRIPT
>>>> +#undef CONFIG_CMD_LOADS
>>>
>>> These are fine to leave in 'tho.
>>
>> These are no useful for us.
>> I will consider remove unneeded #undef
>
> Right.
Ditto.
>>> And please check things with checkpatch.pl, I
>>> thought I saw a '#define<tab>FOO' in there. Thanks!
>>
>> I have checked this patch with checkpatch.pl, and get no errors and
>> no warnings.
>
> OK, thanks.
Best Regards,
Bo Shen
next prev parent reply other threads:[~2013-03-05 2:23 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-28 7:00 [U-Boot] [PATCH 0/4] ARM: atmel: add sama5d3xek board support Bo Shen
2013-02-28 7:00 ` [U-Boot] [PATCH 1/4] USB: ohci-at91: support sama5d3x devices Bo Shen
2013-03-07 9:12 ` Andreas Bießmann
2013-03-08 1:21 ` Bo Shen
2013-02-28 7:00 ` [U-Boot] [PATCH 2/4] NET: macb: " Bo Shen
2013-03-07 9:15 ` Andreas Bießmann
2013-02-28 7:00 ` [U-Boot] [PATCH 3/4] SPI: atmel_spi: " Bo Shen
2013-02-28 7:00 ` [U-Boot] [PATCH 4/4] ARM: atmel: add sama5d3xek support Bo Shen
2013-03-04 15:14 ` Tom Rini
2013-03-05 2:03 ` Bo Shen
2013-03-05 2:20 ` Tom Rini
2013-03-05 2:23 ` Bo Shen [this message]
2013-03-07 10:58 ` Andreas Bießmann
2013-03-08 3:31 ` Bo Shen
2013-03-08 7:32 ` Andreas Bießmann
2013-03-08 8:37 ` Bo Shen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5135571A.5060700@atmel.com \
--to=voice.shen@atmel.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.