From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from perceval.ideasonboard.com ([213.167.242.64]:53388 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726440AbeJPGMh (ORCPT ); Tue, 16 Oct 2018 02:12:37 -0400 From: Laurent Pinchart To: Fabrizio Castro Cc: David Airlie , Rob Herring , Geert Uytterhoeven , Mark Rutland , Biju Das , Simon Horman , Magnus Damm , Russell King , dri-devel@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Chris Paterson Subject: Re: [PATCH 4/5] drm: rcar-du: Add R8A7744 support Date: Tue, 16 Oct 2018 01:25:28 +0300 Message-ID: <5135719.5JoeYGyzrK@avalon> In-Reply-To: <1537553311-8831-5-git-send-email-fabrizio.castro@bp.renesas.com> References: <1537553311-8831-1-git-send-email-fabrizio.castro@bp.renesas.com> <1537553311-8831-5-git-send-email-fabrizio.castro@bp.renesas.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-renesas-soc-owner@vger.kernel.org List-ID: Hi Fabrizio, Thank you for the patch. On Friday, 21 September 2018 21:08:30 EEST Fabrizio Castro wrote: > From: Biju Das > > Add support for the R8A7744 DU (which is very similar to the R8A7743 DU); > it has 1 DPAD (RGB) output and 1 LVDS output. > > Signed-off-by: Biju Das > Reviewed-by: Fabrizio Castro > --- > drivers/gpu/drm/rcar-du/rcar_du_drv.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/rcar-du/rcar_du_drv.c > b/drivers/gpu/drm/rcar-du/rcar_du_drv.c index c07d3f1..2c3d0e5 100644 > --- a/drivers/gpu/drm/rcar-du/rcar_du_drv.c > +++ b/drivers/gpu/drm/rcar-du/rcar_du_drv.c > @@ -321,6 +321,7 @@ static const struct rcar_du_device_info > rcar_du_r8a77970_info = { > > static const struct of_device_id rcar_du_of_table[] = { > { .compatible = "renesas,du-r8a7743", .data = &rzg1_du_r8a7743_info }, > + { .compatible = "renesas,du-r8a7744", .data = &rzg1_du_r8a7743_info }, > { .compatible = "renesas,du-r8a7745", .data = &rzg1_du_r8a7745_info }, > { .compatible = "renesas,du-r8a77470", .data = &rzg1_du_r8a77470_info }, > { .compatible = "renesas,du-r8a7779", .data = &rcar_du_r8a7779_info }, This looks good to me. I would also apply this change: @@ -41,7 +41,7 @@ static const struct rcar_du_device_info rzg1_du_r8a7743_info = { .channels_mask = BIT(1) | BIT(0), .routes = { /* - * R8A7743 has one RGB output and one LVDS output + * R8A774[34] has one RGB output and one LVDS output */ [RCAR_DU_OUTPUT_DPAD0] = { .possible_crtcs = BIT(1) | BIT(0), With this, Reviewed-by: Laurent Pinchart There's no need to resubmit, I've applied the patch to my tree with the above change. -- Regards, Laurent Pinchart From mboxrd@z Thu Jan 1 00:00:00 1970 From: laurent.pinchart@ideasonboard.com (Laurent Pinchart) Date: Tue, 16 Oct 2018 01:25:28 +0300 Subject: [PATCH 4/5] drm: rcar-du: Add R8A7744 support In-Reply-To: <1537553311-8831-5-git-send-email-fabrizio.castro@bp.renesas.com> References: <1537553311-8831-1-git-send-email-fabrizio.castro@bp.renesas.com> <1537553311-8831-5-git-send-email-fabrizio.castro@bp.renesas.com> Message-ID: <5135719.5JoeYGyzrK@avalon> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Fabrizio, Thank you for the patch. On Friday, 21 September 2018 21:08:30 EEST Fabrizio Castro wrote: > From: Biju Das > > Add support for the R8A7744 DU (which is very similar to the R8A7743 DU); > it has 1 DPAD (RGB) output and 1 LVDS output. > > Signed-off-by: Biju Das > Reviewed-by: Fabrizio Castro > --- > drivers/gpu/drm/rcar-du/rcar_du_drv.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/rcar-du/rcar_du_drv.c > b/drivers/gpu/drm/rcar-du/rcar_du_drv.c index c07d3f1..2c3d0e5 100644 > --- a/drivers/gpu/drm/rcar-du/rcar_du_drv.c > +++ b/drivers/gpu/drm/rcar-du/rcar_du_drv.c > @@ -321,6 +321,7 @@ static const struct rcar_du_device_info > rcar_du_r8a77970_info = { > > static const struct of_device_id rcar_du_of_table[] = { > { .compatible = "renesas,du-r8a7743", .data = &rzg1_du_r8a7743_info }, > + { .compatible = "renesas,du-r8a7744", .data = &rzg1_du_r8a7743_info }, > { .compatible = "renesas,du-r8a7745", .data = &rzg1_du_r8a7745_info }, > { .compatible = "renesas,du-r8a77470", .data = &rzg1_du_r8a77470_info }, > { .compatible = "renesas,du-r8a7779", .data = &rcar_du_r8a7779_info }, This looks good to me. I would also apply this change: @@ -41,7 +41,7 @@ static const struct rcar_du_device_info rzg1_du_r8a7743_info = { .channels_mask = BIT(1) | BIT(0), .routes = { /* - * R8A7743 has one RGB output and one LVDS output + * R8A774[34] has one RGB output and one LVDS output */ [RCAR_DU_OUTPUT_DPAD0] = { .possible_crtcs = BIT(1) | BIT(0), With this, Reviewed-by: Laurent Pinchart There's no need to resubmit, I've applied the patch to my tree with the above change. -- Regards, Laurent Pinchart From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH 4/5] drm: rcar-du: Add R8A7744 support Date: Tue, 16 Oct 2018 01:25:28 +0300 Message-ID: <5135719.5JoeYGyzrK@avalon> References: <1537553311-8831-1-git-send-email-fabrizio.castro@bp.renesas.com> <1537553311-8831-5-git-send-email-fabrizio.castro@bp.renesas.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1537553311-8831-5-git-send-email-fabrizio.castro@bp.renesas.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Fabrizio Castro Cc: Mark Rutland , devicetree@vger.kernel.org, Chris Paterson , Geert Uytterhoeven , Simon Horman , David Airlie , Magnus Damm , Russell King , dri-devel@lists.freedesktop.org, Biju Das , linux-renesas-soc@vger.kernel.org, Rob Herring , linux-arm-kernel@lists.infradead.org List-Id: devicetree@vger.kernel.org SGkgRmFicml6aW8sCgpUaGFuayB5b3UgZm9yIHRoZSBwYXRjaC4gCgpPbiBGcmlkYXksIDIxIFNl cHRlbWJlciAyMDE4IDIxOjA4OjMwIEVFU1QgRmFicml6aW8gQ2FzdHJvIHdyb3RlOgo+IEZyb206 IEJpanUgRGFzIDxiaWp1LmRhc0BicC5yZW5lc2FzLmNvbT4KPiAKPiBBZGQgc3VwcG9ydCBmb3Ig dGhlIFI4QTc3NDQgRFUgKHdoaWNoIGlzIHZlcnkgc2ltaWxhciB0byB0aGUgUjhBNzc0MyBEVSk7 Cj4gaXQgaGFzIDEgRFBBRCAoUkdCKSBvdXRwdXQgYW5kIDEgTFZEUyBvdXRwdXQuCj4gCj4gU2ln bmVkLW9mZi1ieTogQmlqdSBEYXMgPGJpanUuZGFzQGJwLnJlbmVzYXMuY29tPgo+IFJldmlld2Vk LWJ5OiBGYWJyaXppbyBDYXN0cm8gPGZhYnJpemlvLmNhc3Ryb0BicC5yZW5lc2FzLmNvbT4KPiAt LS0KPiAgZHJpdmVycy9ncHUvZHJtL3JjYXItZHUvcmNhcl9kdV9kcnYuYyB8IDEgKwo+ICAxIGZp bGUgY2hhbmdlZCwgMSBpbnNlcnRpb24oKykKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUv ZHJtL3JjYXItZHUvcmNhcl9kdV9kcnYuYwo+IGIvZHJpdmVycy9ncHUvZHJtL3JjYXItZHUvcmNh cl9kdV9kcnYuYyBpbmRleCBjMDdkM2YxLi4yYzNkMGU1IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMv Z3B1L2RybS9yY2FyLWR1L3JjYXJfZHVfZHJ2LmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vcmNh ci1kdS9yY2FyX2R1X2Rydi5jCj4gQEAgLTMyMSw2ICszMjEsNyBAQCBzdGF0aWMgY29uc3Qgc3Ry dWN0IHJjYXJfZHVfZGV2aWNlX2luZm8KPiByY2FyX2R1X3I4YTc3OTcwX2luZm8gPSB7Cj4gCj4g IHN0YXRpYyBjb25zdCBzdHJ1Y3Qgb2ZfZGV2aWNlX2lkIHJjYXJfZHVfb2ZfdGFibGVbXSA9IHsK PiAgCXsgLmNvbXBhdGlibGUgPSAicmVuZXNhcyxkdS1yOGE3NzQzIiwgLmRhdGEgPSAmcnpnMV9k dV9yOGE3NzQzX2luZm8gfSwKPiArCXsgLmNvbXBhdGlibGUgPSAicmVuZXNhcyxkdS1yOGE3NzQ0 IiwgLmRhdGEgPSAmcnpnMV9kdV9yOGE3NzQzX2luZm8gfSwKPiAgCXsgLmNvbXBhdGlibGUgPSAi cmVuZXNhcyxkdS1yOGE3NzQ1IiwgLmRhdGEgPSAmcnpnMV9kdV9yOGE3NzQ1X2luZm8gfSwKPiAg CXsgLmNvbXBhdGlibGUgPSAicmVuZXNhcyxkdS1yOGE3NzQ3MCIsIC5kYXRhID0gJnJ6ZzFfZHVf cjhhNzc0NzBfaW5mbyB9LAo+ICAJeyAuY29tcGF0aWJsZSA9ICJyZW5lc2FzLGR1LXI4YTc3Nzki LCAuZGF0YSA9ICZyY2FyX2R1X3I4YTc3NzlfaW5mbyB9LAoKVGhpcyBsb29rcyBnb29kIHRvIG1l LiBJIHdvdWxkIGFsc28gYXBwbHkgdGhpcyBjaGFuZ2U6CgpAQCAtNDEsNyArNDEsNyBAQCBzdGF0 aWMgY29uc3Qgc3RydWN0IHJjYXJfZHVfZGV2aWNlX2luZm8gcnpnMV9kdV9yOGE3NzQzX2luZm8g Cj0gewogICAgICAgIC5jaGFubmVsc19tYXNrID0gQklUKDEpIHwgQklUKDApLAogICAgICAgIC5y b3V0ZXMgPSB7CiAgICAgICAgICAgICAgICAvKgotICAgICAgICAgICAgICAgICogUjhBNzc0MyBo YXMgb25lIFJHQiBvdXRwdXQgYW5kIG9uZSBMVkRTIG91dHB1dAorICAgICAgICAgICAgICAgICog UjhBNzc0WzM0XSBoYXMgb25lIFJHQiBvdXRwdXQgYW5kIG9uZSBMVkRTIG91dHB1dAogICAgICAg ICAgICAgICAgICovCiAgICAgICAgICAgICAgICBbUkNBUl9EVV9PVVRQVVRfRFBBRDBdID0gewog ICAgICAgICAgICAgICAgICAgICAgICAucG9zc2libGVfY3J0Y3MgPSBCSVQoMSkgfCBCSVQoMCks CgpXaXRoIHRoaXMsCgpSZXZpZXdlZC1ieTogTGF1cmVudCBQaW5jaGFydCA8bGF1cmVudC5waW5j aGFydEBpZGVhc29uYm9hcmQuY29tPgoKVGhlcmUncyBubyBuZWVkIHRvIHJlc3VibWl0LCBJJ3Zl IGFwcGxpZWQgdGhlIHBhdGNoIHRvIG15IHRyZWUgd2l0aCB0aGUgYWJvdmUgCmNoYW5nZS4KCi0t IApSZWdhcmRzLAoKTGF1cmVudCBQaW5jaGFydAoKCgpfX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBs aXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1h bi9saXN0aW5mby9kcmktZGV2ZWwK