From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from [222.73.24.84] (helo=song.cn.fujitsu.com) by merlin.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1UCoDB-0004uP-Uo for kexec@lists.infradead.org; Tue, 05 Mar 2013 09:31:07 +0000 Message-ID: <5135BAE8.8050405@cn.fujitsu.com> Date: Tue, 05 Mar 2013 17:29:12 +0800 From: Zhang Yanfei MIME-Version: 1.0 Subject: Re: [PATCH v2 03/20] vmcore, sysfs: export ELF note segment size instead of vmcoreinfo data size References: <20130302083447.31252.93914.stgit@localhost6.localdomain6> <20130302083605.31252.26646.stgit@localhost6.localdomain6> In-Reply-To: <20130302083605.31252.26646.stgit@localhost6.localdomain6> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "kexec" Errors-To: kexec-bounces+dwmw2=infradead.org@lists.infradead.org To: HATAYAMA Daisuke Cc: kexec@lists.infradead.org, heiko.carstens@de.ibm.com, linux-kernel@vger.kernel.org, lisa.mitchell@hp.com, kumagai-atsushi@mxc.nes.nec.co.jp, ebiederm@xmission.com, akpm@linux-foundation.org, cpw@sgi.com, vgoyal@redhat.com 5LqOIDIwMTPlubQwM+aciDAy5pelIDE2OjM2LCBIQVRBWUFNQSBEYWlzdWtlIOWGmemBkzoKPiBw X21lbXN6IG1lbWJlciBvZiBwcm9ncmFtIGhlYWRlciBlbnRyeSB3aXRoIFBUX05PVEUgdHlwZSBu ZWVkcyB0byBoYXZlCj4gc2l6ZSBvZiB0aGUgY29ycmVzcG9uZGluZyBFTEYgbm90ZSBzZWdtZW50 LiBDdXJyZW50bHksIHZtY29yZWluZm8KPiBleHBvcnRzIGRhdGEgcGFydCBvbmx5LiBJZiB2bWNv cmVpbmZvIHJlYWNocyB2bWNvcmVpbmZvX21heF9zaXplLCB0aGVuCj4gaW4gbWVyZ2Vfbm90ZV9o ZWFkZXJzX2VsZnszMiw2NH0sIGVtcHR5IEVMRiBub3RlIGhlYWRlciBjYW5ub3QgYmUKPiBmb3Vu ZCBvciBidWZmZXIgb3ZlcnJ1biBjYW4gaGFwcGVuLgo+IAo+IE5vdGU6IGtleGVjLXRvb2xzIGFz c2lnbnMgUEFHRV9TSVpFIHRvIHBfbWVtc3ogZm9yIG90aGVyIEVMRiBub3RlCj4gdHlwZXMuIER1 ZSB0byB0aGUgYWJvdmUgcmVhc29uLCB0aGUgc2FtZSBpc3N1ZSBvY2N1cnMgaWYgYWN0dWFsIEVM Rgo+IG5vdGUgZGF0YSBleGNlZWRzIChQQUdFX1NJWkUgLSAyICogS0VYRUNfTk9URV9IRUFEX0JZ VEVTKS4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBIQVRBWUFNQSBEYWlzdWtlIDxkLmhhdGF5YW1hQGpw LmZ1aml0c3UuY29tPgo+IC0tLQo+IAo+ICBrZXJuZWwva3N5c2ZzLmMgfCAgICAyICstCj4gIDEg ZmlsZXMgY2hhbmdlZCwgMSBpbnNlcnRpb25zKCspLCAxIGRlbGV0aW9ucygtKQo+IAo+IGRpZmYg LS1naXQgYS9rZXJuZWwva3N5c2ZzLmMgYi9rZXJuZWwva3N5c2ZzLmMKPiBpbmRleCA2YWRhOTNj Li45N2QyNzYzIDEwMDY0NAo+IC0tLSBhL2tlcm5lbC9rc3lzZnMuYwo+ICsrKyBiL2tlcm5lbC9r c3lzZnMuYwo+IEBAIC0xMjYsNyArMTI2LDcgQEAgc3RhdGljIHNzaXplX3Qgdm1jb3JlaW5mb19z aG93KHN0cnVjdCBrb2JqZWN0ICprb2JqLAo+ICB7Cj4gIAlyZXR1cm4gc3ByaW50ZihidWYsICIl bHggJXhcbiIsCj4gIAkJICAgICAgIHBhZGRyX3ZtY29yZWluZm9fbm90ZSgpLAo+IC0JCSAgICAg ICAodW5zaWduZWQgaW50KXZtY29yZWluZm9fbWF4X3NpemUpOwo+ICsJCSAgICAgICAodW5zaWdu ZWQgaW50KXNpemVvZih2bWNvcmVpbmZvX25vdGUpKTsKPiAgfQo+ICBLRVJORUxfQVRUUl9STyh2 bWNvcmVpbmZvKTsKClJldmlld2VkLWJ5OiBaaGFuZyBZYW5mZWkgPHpoYW5neWFuZmVpQGNuLmZ1 aml0c3UuY29tPgoKPiAgCj4gCj4gCj4gX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX18KPiBrZXhlYyBtYWlsaW5nIGxpc3QKPiBrZXhlY0BsaXN0cy5pbmZyYWRl YWQub3JnCj4gaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9rZXhl Ywo+IAoKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmtl eGVjIG1haWxpbmcgbGlzdAprZXhlY0BsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5p bmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8va2V4ZWMK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755507Ab3CEJbI (ORCPT ); Tue, 5 Mar 2013 04:31:08 -0500 Received: from cn.fujitsu.com ([222.73.24.84]:44594 "EHLO song.cn.fujitsu.com" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1755104Ab3CEJbF convert rfc822-to-8bit (ORCPT ); Tue, 5 Mar 2013 04:31:05 -0500 X-IronPort-AV: E=Sophos;i="4.84,786,1355068800"; d="scan'208";a="6816564" Message-ID: <5135BAE8.8050405@cn.fujitsu.com> Date: Tue, 05 Mar 2013 17:29:12 +0800 From: Zhang Yanfei User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0.8) Gecko/20121012 Thunderbird/10.0.8 MIME-Version: 1.0 To: HATAYAMA Daisuke CC: vgoyal@redhat.com, ebiederm@xmission.com, cpw@sgi.com, kumagai-atsushi@mxc.nes.nec.co.jp, lisa.mitchell@hp.com, heiko.carstens@de.ibm.com, akpm@linux-foundation.org, kexec@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 03/20] vmcore, sysfs: export ELF note segment size instead of vmcoreinfo data size References: <20130302083447.31252.93914.stgit@localhost6.localdomain6> <20130302083605.31252.26646.stgit@localhost6.localdomain6> In-Reply-To: <20130302083605.31252.26646.stgit@localhost6.localdomain6> X-MIMETrack: Itemize by SMTP Server on mailserver/fnst(Release 8.5.3|September 15, 2011) at 2013/03/05 17:30:02, Serialize by Router on mailserver/fnst(Release 8.5.3|September 15, 2011) at 2013/03/05 17:30:02 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 于 2013年03月02日 16:36, HATAYAMA Daisuke 写道: > p_memsz member of program header entry with PT_NOTE type needs to have > size of the corresponding ELF note segment. Currently, vmcoreinfo > exports data part only. If vmcoreinfo reachs vmcoreinfo_max_size, then > in merge_note_headers_elf{32,64}, empty ELF note header cannot be > found or buffer overrun can happen. > > Note: kexec-tools assigns PAGE_SIZE to p_memsz for other ELF note > types. Due to the above reason, the same issue occurs if actual ELF > note data exceeds (PAGE_SIZE - 2 * KEXEC_NOTE_HEAD_BYTES). > > Signed-off-by: HATAYAMA Daisuke > --- > > kernel/ksysfs.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/kernel/ksysfs.c b/kernel/ksysfs.c > index 6ada93c..97d2763 100644 > --- a/kernel/ksysfs.c > +++ b/kernel/ksysfs.c > @@ -126,7 +126,7 @@ static ssize_t vmcoreinfo_show(struct kobject *kobj, > { > return sprintf(buf, "%lx %x\n", > paddr_vmcoreinfo_note(), > - (unsigned int)vmcoreinfo_max_size); > + (unsigned int)sizeof(vmcoreinfo_note)); > } > KERNEL_ATTR_RO(vmcoreinfo); Reviewed-by: Zhang Yanfei > > > > _______________________________________________ > kexec mailing list > kexec@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/kexec >