From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:38519) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UCq0M-00057V-8g for qemu-devel@nongnu.org; Tue, 05 Mar 2013 06:26:03 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UCq0K-0003ze-Hr for qemu-devel@nongnu.org; Tue, 05 Mar 2013 06:25:58 -0500 Received: from mx1.redhat.com ([209.132.183.28]:27391) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UCq0K-0003za-An for qemu-devel@nongnu.org; Tue, 05 Mar 2013 06:25:56 -0500 Message-ID: <5135D63F.2060108@redhat.com> Date: Tue, 05 Mar 2013 12:25:51 +0100 From: Gerd Hoffmann MIME-Version: 1.0 References: <1362418348-27398-1-git-send-email-pbonzini@redhat.com> <51350131.1070703@redhat.com> <5135CFE7.7040506@redhat.com> In-Reply-To: <5135CFE7.7040506@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] sysbus: add no_user for devices using mmio or IRQ or GPIO List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: Peter Maydell , Anthony Liguori , qemu-devel@nongnu.org On 03/05/13 11:58, Paolo Bonzini wrote: > Il 05/03/2013 00:22, Peter Maydell ha scritto: >>> Yes, the right thing to do would be to QOMify memory regions and >>> introduce pins, but that's a bit more than the amount of time I have now >>> for this. >> >> ...plus it means that when we do have these things we >> have to go round and identify the cases where no_user >> was set only because we didn't have the features before. > > Yes, that's why my patch includes a comment to this end. > >> My attitude here really is "yes, it's not great but it's >> been like this forever and we don't seem to have had a >> huge flood of user complaints, so better not to mess >> with it unless what you're doing is going to amount to >> some kind of cleanup". > > I did find a complaint from a Red Hat tester about having the sysbus > EHCI device in the help. I guess an alternative fix will be to move > those device to a separate CONFIG_ symbol. Or just exclude any sysbus device? Or will that kill too much? cheers, Gerd