From: David Vrabel <david.vrabel@citrix.com>
To: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Cc: Wei Liu <wei.liu2@citrix.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"annie.li@oracle.com" <annie.li@oracle.com>,
Ian Campbell <Ian.Campbell@citrix.com>,
"xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
Subject: Re: [Xen-devel] [PATCH 1/8] netback: don't bind kthread to cpu
Date: Tue, 5 Mar 2013 14:42:26 +0000 [thread overview]
Message-ID: <51360452.5070200@citrix.com> (raw)
In-Reply-To: <20130305135649.GA2589@phenom.dumpdata.com>
On 05/03/13 13:56, Konrad Rzeszutek Wilk wrote:
> On Tue, Mar 05, 2013 at 01:30:10PM +0000, Wei Liu wrote:
>> On Mon, 2013-03-04 at 20:51 +0000, Konrad Rzeszutek Wilk wrote:
>>> On Fri, Feb 15, 2013 at 04:00:02PM +0000, Wei Liu wrote:
>>>> The initialization process makes an assumption that the online cpus are
>>>> numbered from 0 to xen_netbk_group_nr-1, which is not always true.
>>>
>>> And xen_netbk_group_nr is num_online_cpus()?
>>>
>>
>> Yes.
>>
>>> So under what conditions does this change? Is this when the CPU hotplug
>>> is involved and the CPUs go offline? In which case should there be a
>>
>> Yes, the hotplug path.
>>
>>> CPU hotplug notifier to re-bind the workers are appropiate?
>
> ?
> Can't that option be explored?
I'm not sure binding netback threads to particular VCPUs is useful
without also binding the events to the corresponding VCPUs.
I would hope that the scheduler would tend to the correct behavior if
threads aren't bound, anyway.
David
next prev parent reply other threads:[~2013-03-05 14:42 UTC|newest]
Thread overview: 91+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-15 16:00 [PATCH 0/8] Bugfix and mechanical works for Xen network driver Wei Liu
2013-02-15 16:00 ` [PATCH 1/8] netback: don't bind kthread to cpu Wei Liu
2013-03-04 20:51 ` Konrad Rzeszutek Wilk
2013-03-04 20:51 ` Konrad Rzeszutek Wilk
2013-03-05 13:30 ` Wei Liu
2013-03-05 13:30 ` Wei Liu
2013-03-05 13:56 ` Konrad Rzeszutek Wilk
2013-03-05 13:56 ` [Xen-devel] " Konrad Rzeszutek Wilk
2013-03-05 14:04 ` Wei Liu
2013-03-05 14:04 ` Wei Liu
2013-03-05 14:42 ` David Vrabel
2013-03-05 14:42 ` David Vrabel [this message]
2013-03-05 15:52 ` [Xen-devel] " Konrad Rzeszutek Wilk
2013-03-05 15:52 ` Konrad Rzeszutek Wilk
2013-02-15 16:00 ` Wei Liu
2013-02-15 16:00 ` [PATCH 2/8] netback: add module unload function Wei Liu
2013-03-04 20:55 ` Konrad Rzeszutek Wilk
2013-03-04 20:55 ` [Xen-devel] " Konrad Rzeszutek Wilk
2013-03-04 20:58 ` Andrew Cooper
2013-03-04 20:58 ` Andrew Cooper
2013-03-05 13:30 ` [Xen-devel] " Wei Liu
2013-03-05 13:30 ` Wei Liu
2013-03-04 21:58 ` Stephen Hemminger
2013-03-05 13:30 ` Wei Liu
2013-03-05 13:30 ` Wei Liu
2013-03-04 21:58 ` Stephen Hemminger
2013-02-15 16:00 ` Wei Liu
2013-02-15 16:00 ` [PATCH 3/8] netback: get/put module along with vif connect/disconnect Wei Liu
2013-03-04 20:56 ` Konrad Rzeszutek Wilk
2013-03-04 20:56 ` Konrad Rzeszutek Wilk
2013-03-05 10:02 ` [Xen-devel] " David Vrabel
2013-03-05 13:30 ` Wei Liu
2013-03-05 14:07 ` David Vrabel
2013-03-05 14:44 ` Wei Liu
2013-03-05 14:44 ` Wei Liu
2013-03-05 15:53 ` [Xen-devel] " Konrad Rzeszutek Wilk
2013-03-05 15:53 ` Konrad Rzeszutek Wilk
2013-03-05 14:07 ` David Vrabel
2013-03-05 13:30 ` Wei Liu
2013-03-05 10:02 ` David Vrabel
2013-02-15 16:00 ` Wei Liu
2013-02-15 16:00 ` [PATCH 4/8] xenbus_client: Extend interface to support multi-page ring Wei Liu
2013-02-15 16:00 ` Wei Liu
2013-02-15 16:17 ` [Xen-devel] " Jan Beulich
2013-02-15 16:33 ` Wei Liu
2013-02-15 16:33 ` [Xen-devel] " Wei Liu
2013-02-15 16:59 ` Jan Beulich
2013-02-15 16:59 ` [Xen-devel] " Jan Beulich
2013-02-15 17:01 ` Wei Liu
2013-02-15 17:01 ` Wei Liu
2013-02-15 16:17 ` Jan Beulich
2013-03-04 21:12 ` Konrad Rzeszutek Wilk
2013-03-04 21:12 ` Konrad Rzeszutek Wilk
2013-03-05 10:25 ` [Xen-devel] " David Vrabel
2013-03-05 10:25 ` David Vrabel
2013-02-15 16:00 ` [PATCH 5/8] netback: multi-page ring support Wei Liu
2013-03-04 21:00 ` Konrad Rzeszutek Wilk
2013-03-04 21:00 ` [Xen-devel] " Konrad Rzeszutek Wilk
2013-03-05 10:41 ` David Vrabel
2013-03-05 10:41 ` [Xen-devel] " David Vrabel
2013-02-15 16:00 ` Wei Liu
2013-02-15 16:00 ` [PATCH 6/8] netfront: " Wei Liu
2013-02-26 6:52 ` ANNIE LI
2013-02-26 6:52 ` ANNIE LI
2013-02-26 12:35 ` Wei Liu
2013-02-27 7:39 ` ANNIE LI
2013-02-27 15:49 ` Wei Liu
2013-02-28 5:19 ` ANNIE LI
2013-02-28 5:19 ` ANNIE LI
2013-02-28 11:02 ` Wei Liu
2013-02-28 12:55 ` annie li
2013-02-28 12:55 ` annie li
2013-02-28 11:02 ` Wei Liu
2013-02-27 15:49 ` Wei Liu
2013-02-27 7:39 ` ANNIE LI
2013-02-26 12:35 ` Wei Liu
2013-03-04 21:16 ` Konrad Rzeszutek Wilk
2013-03-04 21:16 ` Konrad Rzeszutek Wilk
2013-02-15 16:00 ` Wei Liu
2013-02-15 16:00 ` [PATCH 7/8] netback: split event channels support Wei Liu
2013-02-15 16:00 ` Wei Liu
2013-03-04 21:22 ` Konrad Rzeszutek Wilk
2013-03-04 21:22 ` Konrad Rzeszutek Wilk
2013-02-15 16:00 ` [PATCH 8/8] netfront: " Wei Liu
2013-03-04 21:24 ` Konrad Rzeszutek Wilk
2013-03-04 21:24 ` Konrad Rzeszutek Wilk
2013-02-15 16:00 ` Wei Liu
2013-02-26 3:07 ` [Xen-devel] [PATCH 0/8] Bugfix and mechanical works for Xen network driver ANNIE LI
2013-02-26 11:33 ` Wei Liu
2013-02-26 11:33 ` [Xen-devel] " Wei Liu
2013-02-26 3:07 ` ANNIE LI
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51360452.5070200@citrix.com \
--to=david.vrabel@citrix.com \
--cc=Ian.Campbell@citrix.com \
--cc=annie.li@oracle.com \
--cc=konrad.wilk@oracle.com \
--cc=netdev@vger.kernel.org \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.