From: Hannes Reinecke <hare@suse.de>
To: Kay Sievers <kay@vrfy.org>
Cc: David Milburn <dmilburn@redhat.com>,
jgarzik@pobox.com, linux-ide@vger.kernel.org,
coughlan@redhat.com, fengguang.wu@intel.com, gwendal@google.com
Subject: Re: [PATCH #upstream] libata: export local port number through /sys
Date: Tue, 05 Mar 2013 16:48:32 +0100 [thread overview]
Message-ID: <513613D0.9090904@suse.de> (raw)
In-Reply-To: <CAPXgP13Q3TyWPwE3CqhiqouLQH-oyr8EC=wHChy50he74qokug@mail.gmail.com>
On 02/26/2013 04:26 PM, Kay Sievers wrote:
> On Mon, Feb 25, 2013 at 10:04 PM, David Milburn <dmilburn@redhat.com> wrote:
>> David Milburn wrote:
>>>
>>> Export <global port>.<local port> format through /sys
>>>
>>> ./pci0000:00/0000:00:1f.2/ata1.1
>>> ./pci0000:00/0000:00:1f.2/ata1.1/link1.1/dev1.1.0/ata_device
>>> ./pci0000:00/0000:00:1f.2/ata1.1/link1.1/ata_link
>>> ./pci0000:00/0000:00:1f.2/ata1.1/ata_port
>>> ./pci0000:00/0000:00:1f.2/ata1.1/ata_port/ata1.1
>>> ./pci0000:00/0000:00:1f.2/ata2.2
>>> ./pci0000:00/0000:00:1f.2/ata2.2/link2.2/dev2.2.0/ata_device
>>> ./pci0000:00/0000:00:1f.2/ata2.2/link2.2/ata_link
>>> ./pci0000:00/0000:00:1f.2/ata2.2/ata_port
>>> ./pci0000:00/0000:00:1f.2/ata2.2/ata_port/ata2.2
>>> ./pci0000:00/0000:00:1f.2/ata3.3
>>> ./pci0000:00/0000:00:1f.2/ata3.3/link3.3/dev3.3.0/ata_device
>>> ./pci0000:00/0000:00:1f.2/ata3.3/link3.3/ata_link
>>> ./pci0000:00/0000:00:1f.2/ata3.3/ata_port
>>> ./pci0000:00/0000:00:1f.2/ata3.3/ata_port/ata3.3
>>> ./pci0000:00/0000:00:1f.2/ata4.4
>>> ./pci0000:00/0000:00:1f.2/ata4.4/link4.4/dev4.4.0/ata_device
>>> ./pci0000:00/0000:00:1f.2/ata4.4/link4.4/ata_link
>>> ./pci0000:00/0000:00:1f.2/ata4.4/ata_port
>>> ./pci0000:00/0000:00:1f.2/ata4.4/ata_port/ata4.4
>>> ./pci0000:00/0000:00:1f.2/ata5.5
>>> ./pci0000:00/0000:00:1f.2/ata5.5/link5.5/dev5.5.0/ata_device
>>> ./pci0000:00/0000:00:1f.2/ata5.5/link5.5/ata_link
>>> ./pci0000:00/0000:00:1f.2/ata5.5/ata_port
>>> ./pci0000:00/0000:00:1f.2/ata5.5/ata_port/ata5.5
>>> ./pci0000:00/0000:00:1f.2/ata6.6
>>> ./pci0000:00/0000:00:1f.2/ata6.6/link6.6/dev6.6.0/ata_device
>>> ./pci0000:00/0000:00:1f.2/ata6.6/link6.6/ata_link
>>> ./pci0000:00/0000:00:1f.2/ata6.6/ata_port
>>> ./pci0000:00/0000:00:1f.2/ata6.6/ata_port/ata6.6
>>>
Hmm.
Can't say I like the 'global port' notation.
Personally I would prefer to have a sysfs attribute for the local
port number, and have path_id get it from there.
For 95% of all cases the above is just an information duplication
(ie it'll only provide a real value for udev, but not for the user).
So, please, use a sysfs attribute for the local port and keep the
numbering as it is.
Cheers,
Hannes
--
Dr. Hannes Reinecke zSeries & Storage
hare@suse.de +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)
next prev parent reply other threads:[~2013-03-05 15:48 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-24 17:52 [PATCH #upstream] libata: export local port number through /sys David Milburn
2013-02-25 21:04 ` David Milburn
2013-02-25 21:16 ` Jeff Garzik
2013-02-26 15:26 ` Kay Sievers
2013-03-05 15:48 ` Hannes Reinecke [this message]
2013-03-05 23:04 ` David Milburn
2013-03-06 7:10 ` Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=513613D0.9090904@suse.de \
--to=hare@suse.de \
--cc=coughlan@redhat.com \
--cc=dmilburn@redhat.com \
--cc=fengguang.wu@intel.com \
--cc=gwendal@google.com \
--cc=jgarzik@pobox.com \
--cc=kay@vrfy.org \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.