Re: [PATCH 1/5] libceph: isolate message page field manipulation

[Alex Elder <elder@inktank.com>]

On 03/05/2013 07:52 AM, Alex Elder wrote:
> +void ceph_msg_data_set_pages(struct ceph_msg *msg, struct page **pages,
> +		unsigned int page_count, size_t alignment)
> +{
> +	/* BUG_ON(!pages); */
> +	/* BUG_ON(!page_count); */
> +	/* BUG_ON(msg->pages); */
> +	/* BUG_ON(msg->page_count); */
> +
> +	msg->pages = pages;
> +	msg->page_count = page_count;
> +	msg->page_alignment = alignment & PAGE_SIZE;

Whoops, this is supposed to be:
	msg->page_alignment = alignment & ~PAGE_MASK;

I think it works despite the bug, it just isn't very
good for performance on the other end...

I will fix this before I commit anything (and after
review).

					-Alex

> +}
> +EXPORT_SYMBOL(ceph_msg_data_set_pages);