From: "Roger Pau Monné" <roger.pau@citrix.com>
To: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Cc: Jan Beulich <JBeulich@suse.com>,
"xen-devel@lists.xen.org" <xen-devel@lists.xen.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [Xen-devel] [PATCH RFC 12/12] xen-block: implement indirect descriptors
Date: Tue, 5 Mar 2013 18:00:51 +0100 [thread overview]
Message-ID: <513624C3.6070808@citrix.com> (raw)
In-Reply-To: <20130305141610.GF2589@phenom.dumpdata.com>
On 05/03/13 15:16, Konrad Rzeszutek Wilk wrote:
> On Tue, Mar 05, 2013 at 08:11:19AM +0000, Jan Beulich wrote:
>>>>> On 04.03.13 at 21:44, Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> wrote:
>>> <nods> 'op' sounds good. With a comment saying it can do all of the
>>> BLKIF_OPS_..
>>> except the BLKIF_OP_INDIRECT one. Thought one could in theory chain
>>> it that way for fun.
>>
>> In fact I'd like to exclude chaining as well as BLKIF_OP_DISCARD here.
>> The former should - if useful for anything - be controlled by a
>> separate feature flag, and the latter is plain pointless to indirect.
>> And I reckon the same would apply to BLKIF_OP_FLUSH_DISKCACHE
>> and BLKIF_OP_RESERVED_1 - i.e. it might be better to state that
>> indirection is only permitted for normal I/O (read/write) ops.
>
> <nods> That makes sense. And also of course the new BLKIF_OP should
> be documented in the Xen tree as well.
The only ops that can be done indirectly are _READ, _WRITE and
_BARRIER/_FLUSH. From the implementation in blkfront it seems like
_FLUSH/_BARRIER requests can indeed contain segments, but I haven't been
able to spot any _FLUSH op with segments on it. Can you confirm FLUSH
requests never contain bios?
next prev parent reply other threads:[~2013-03-05 17:00 UTC|newest]
Thread overview: 101+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-28 10:28 [PATCH RFC 00/12] xen-block: indirect descriptors Roger Pau Monne
2013-02-28 10:28 ` [PATCH RFC 01/12] xen-blkback: don't store dev_bus_addr Roger Pau Monne
2013-02-28 10:58 ` Jan Beulich
2013-02-28 10:58 ` [Xen-devel] " Jan Beulich
2013-03-04 17:19 ` Roger Pau Monné
2013-03-05 8:06 ` Jan Beulich
2013-03-05 8:06 ` [Xen-devel] " Jan Beulich
2013-03-05 17:02 ` Roger Pau Monné
2013-03-05 17:02 ` [Xen-devel] " Roger Pau Monné
2013-03-04 17:19 ` Roger Pau Monné
2013-02-28 10:28 ` Roger Pau Monne
2013-02-28 10:28 ` [PATCH RFC 02/12] xen-blkback: fix foreach_grant_safe to handle empty lists Roger Pau Monne
2013-02-28 10:28 ` Roger Pau Monne
2013-02-28 10:28 ` [PATCH RFC 03/12] xen-blkfront: switch from llist to list Roger Pau Monne
2013-02-28 10:28 ` Roger Pau Monne
2013-02-28 10:28 ` [PATCH RFC 04/12] xen-blkfront: pre-allocate pages for requests Roger Pau Monne
2013-02-28 10:28 ` Roger Pau Monne
2013-03-04 19:39 ` Konrad Rzeszutek Wilk
2013-03-04 19:39 ` Konrad Rzeszutek Wilk
2013-03-05 11:04 ` Roger Pau Monné
2013-03-05 11:04 ` Roger Pau Monné
2013-03-05 14:18 ` Konrad Rzeszutek Wilk
2013-03-05 14:18 ` Konrad Rzeszutek Wilk
2013-03-05 16:30 ` Roger Pau Monné
2013-03-05 16:30 ` Roger Pau Monné
2013-03-05 21:53 ` Konrad Rzeszutek Wilk
2013-03-06 9:17 ` Roger Pau Monné
2013-03-06 9:17 ` Roger Pau Monné
2013-03-05 21:53 ` Konrad Rzeszutek Wilk
2013-02-28 10:28 ` [PATCH RFC 05/12] xen-blkfront: remove frame list from blk_shadow Roger Pau Monne
2013-02-28 10:28 ` Roger Pau Monne
2013-02-28 10:28 ` [PATCH RFC 06/12] xen-blkback: implement LRU mechanism for persistent grants Roger Pau Monne
2013-02-28 10:28 ` Roger Pau Monne
2013-03-04 20:10 ` Konrad Rzeszutek Wilk
2013-03-05 18:10 ` Roger Pau Monné
2013-03-05 21:49 ` Konrad Rzeszutek Wilk
2013-03-05 21:49 ` Konrad Rzeszutek Wilk
2013-03-18 17:00 ` Roger Pau Monné
2013-03-18 17:00 ` Roger Pau Monné
2013-03-05 18:10 ` Roger Pau Monné
2013-03-04 20:10 ` Konrad Rzeszutek Wilk
2013-02-28 10:28 ` [PATCH RFC 07/12] xen-blkback: print stats about " Roger Pau Monne
2013-02-28 10:28 ` Roger Pau Monne
2013-02-28 10:28 ` [PATCH RFC 08/12] xen-blkback: use balloon pages for all mappings Roger Pau Monne
2013-02-28 10:28 ` Roger Pau Monne
2013-03-04 20:22 ` Konrad Rzeszutek Wilk
2013-03-04 20:22 ` Konrad Rzeszutek Wilk
2013-03-26 17:30 ` Roger Pau Monné
2013-03-26 17:30 ` Roger Pau Monné
2013-03-26 17:48 ` Roger Pau Monné
2013-03-26 17:48 ` Roger Pau Monné
2013-02-28 10:28 ` [PATCH RFC 09/12] xen-blkback: move pending handles list from blkbk to pending_req Roger Pau Monne
2013-02-28 10:28 ` Roger Pau Monne
2013-02-28 11:07 ` [Xen-devel] " Jan Beulich
2013-02-28 11:07 ` Jan Beulich
2013-02-28 10:28 ` [PATCH RFC 10/12] xen-blkback: make the queue of free requests per backend Roger Pau Monne
2013-02-28 10:28 ` Roger Pau Monne
2013-02-28 11:08 ` [Xen-devel] " Jan Beulich
2013-02-28 11:08 ` Jan Beulich
2013-02-28 10:28 ` [PATCH RFC 11/12] xen-blkback: expand map/unmap functions Roger Pau Monne
2013-02-28 10:28 ` Roger Pau Monne
2013-02-28 10:28 ` [PATCH RFC 12/12] xen-block: implement indirect descriptors Roger Pau Monne
2013-02-28 10:28 ` Roger Pau Monne
2013-02-28 11:19 ` Jan Beulich
2013-02-28 11:19 ` [Xen-devel] " Jan Beulich
2013-02-28 12:00 ` Roger Pau Monné
2013-02-28 13:28 ` Jan Beulich
2013-02-28 13:28 ` [Xen-devel] " Jan Beulich
2013-03-04 20:44 ` Konrad Rzeszutek Wilk
2013-03-05 8:11 ` Jan Beulich
2013-03-05 14:16 ` Konrad Rzeszutek Wilk
2013-03-05 17:00 ` Roger Pau Monné
2013-03-05 17:00 ` Roger Pau Monné [this message]
2013-03-05 21:45 ` Konrad Rzeszutek Wilk
2013-03-05 21:45 ` [Xen-devel] " Konrad Rzeszutek Wilk
2013-03-05 14:16 ` Konrad Rzeszutek Wilk
2013-03-05 8:11 ` Jan Beulich
2013-03-04 20:44 ` Konrad Rzeszutek Wilk
2013-02-28 12:00 ` Roger Pau Monné
2013-03-04 20:41 ` Konrad Rzeszutek Wilk
2013-03-05 17:07 ` Roger Pau Monné
2013-03-05 17:07 ` Roger Pau Monné
2013-03-05 21:46 ` Konrad Rzeszutek Wilk
2013-03-05 21:46 ` Konrad Rzeszutek Wilk
2013-03-08 17:07 ` Roger Pau Monné
2013-03-22 1:10 ` Konrad Rzeszutek Wilk
2013-03-22 1:10 ` Konrad Rzeszutek Wilk
2013-03-08 17:07 ` Roger Pau Monné
2013-03-04 20:41 ` Konrad Rzeszutek Wilk
2013-03-18 17:06 ` Roger Pau Monné
2013-03-19 14:38 ` Konrad Rzeszutek Wilk
2013-03-19 14:38 ` Konrad Rzeszutek Wilk
2013-03-18 17:06 ` Roger Pau Monné
2013-02-28 10:49 ` [PATCH RFC 00/12] xen-block: " Jan Beulich
2013-02-28 10:49 ` [Xen-devel] " Jan Beulich
2013-02-28 11:25 ` Roger Pau Monné
2013-02-28 11:35 ` Jan Beulich
2013-02-28 11:35 ` [Xen-devel] " Jan Beulich
2013-02-28 11:44 ` Roger Pau Monné
2013-02-28 11:44 ` Roger Pau Monné
2013-02-28 11:25 ` Roger Pau Monné
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=513624C3.6070808@citrix.com \
--to=roger.pau@citrix.com \
--cc=JBeulich@suse.com \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.