From: Mr Dash Four <mr.dash.four@googlemail.com>
To: unlisted-recipients:; (no To-header on input)
Cc: Netfilter Core Team <netfilter-devel@vger.kernel.org>
Subject: Re: [PATCH] nfacct: correct regressions in v1.0.1
Date: Tue, 05 Mar 2013 18:40:28 +0000 [thread overview]
Message-ID: <51363C1C.6010503@googlemail.com> (raw)
In-Reply-To: <20130305135943.GA4369@localhost>
>> -static int _nfacct_cmd_add(char *name, int pkts, int bytes)
>> +static int _nfacct_cmd_add(char *name,
>> + long long unsigned pkts, long long unsigned bytes)
>>
>
> those are still signed, should be unsigned.
>
Noted.
>> - ret = sscanf(buffer, "{ pkts = %lu, bytes = %lu } = %s",
>> + ret = sscanf(buffer, "{ pkts = %llu, bytes = %llu } = %s",
>>
>
> Better use %"PRIu64" given that we're using uint64_t.
>
You learn something new every day. If this is indeed the case, then
another patch coming up in a minute.
> I have applied a patch based on yours.
>
Thanks.
next prev parent reply other threads:[~2013-03-05 18:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-05 12:47 [PATCH] nfacct: correct regressions in v1.0.1 Mr Dash Four
2013-03-05 13:59 ` Pablo Neira Ayuso
2013-03-05 18:40 ` Mr Dash Four [this message]
2013-03-05 18:40 ` [PATCH] libnetfilter_acct: use PRIu64 and remove unnecessary cast Mr Dash Four
2013-03-15 11:47 ` Pablo Neira Ayuso
2013-03-16 14:06 ` Mr Dash Four
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51363C1C.6010503@googlemail.com \
--to=mr.dash.four@googlemail.com \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.