From: Jiri Slaby <jslaby@suse.cz>
To: David Miller <davem@davemloft.net>
Cc: gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org
Subject: Re: WARNING at tty_buffer.c:428 process_one_work()
Date: Tue, 05 Mar 2013 20:44:49 +0100 [thread overview]
Message-ID: <51364B31.1010808@suse.cz> (raw)
In-Reply-To: <20130305.143940.1976678289652676624.davem@davemloft.net>
On 03/05/2013 08:39 PM, David Miller wrote:
> From: Jiri Slaby <jslaby@suse.cz>
> Date: Tue, 05 Mar 2013 12:01:06 +0100
>
>> I left that "if (port->start == NULL)" in sunhv in place because it
>> behaves completely differently. It checks port->start on all paths prior
>> dereferencing it. And it does not stop interrupts on ->shutdown.
>
> But this code really does care if a TTY is attached, because it wants
> to make sure that SYSRQ handling occurs unconditionally, even if there
> is no TTY to queue the characters to.
>
> This is critically important during bootup before the initial shell
> is spawned, if you want to do a SYSRQ register dump or reset out of
> a hung boot.
>
> Whether that test is now ->state == NULL or whatever, the same logic
> still needs to exist in all of these places.
Hi, I must admit I don't understand. I now checked both of them and they
call uart_handle_sysrq_char unconditionally, or?
--
js
suse labs
next prev parent reply other threads:[~2013-03-05 19:44 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-01 21:47 WARNING at tty_buffer.c:428 process_one_work() David Miller
2013-03-01 21:56 ` Greg KH
2013-03-01 22:10 ` David Miller
2013-03-02 4:49 ` Stephen Rothwell
2013-03-02 5:23 ` Al Viro
2013-03-02 6:35 ` David Miller
2013-03-01 22:00 ` David Miller
2013-03-05 11:01 ` Jiri Slaby
2013-03-05 19:39 ` David Miller
2013-03-05 19:44 ` Jiri Slaby [this message]
2013-03-05 20:03 ` David Miller
2013-03-05 20:27 ` Jiri Slaby
2013-03-05 20:33 ` David Miller
2013-03-05 20:34 ` David Miller
2013-03-05 21:43 ` Jiri Slaby
2013-03-05 22:11 ` Jiri Slaby
2013-03-05 20:47 ` Peter Hurley
2013-03-05 20:53 ` David Miller
2013-03-05 21:44 ` Peter Hurley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51364B31.1010808@suse.cz \
--to=jslaby@suse.cz \
--cc=davem@davemloft.net \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.