From: Ryan Mallon <rmallon@gmail.com>
To: Jingoo Han <jg1.han@samsung.com>
Cc: "'Andrew Morton'" <akpm@linux-foundation.org>,
"'LKML'" <linux-kernel@vger.kernel.org>,
"'Richard Purdie'" <rpurdie@rpsys.net>
Subject: Re: [PATCH V2] backlight: ep93xx_bl: remove incorrect __init annotation
Date: Wed, 06 Mar 2013 09:41:54 +1100 [thread overview]
Message-ID: <513674B2.6040106@gmail.com> (raw)
In-Reply-To: <015701ce18b6$f7f42450$e7dc6cf0$%han@samsung.com>
On 04/03/13 20:02, Jingoo Han wrote:
> When platform_driver_probe() is not used, bind/unbind via sysfs is
> enabled. Thus, __init/__exit annotations should be removed from
> probe()/remove().
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Acked-by: Ryan Mallon <rmallon@gmail.com>
> ---
> Changes since v1:
> - Fix typo of the subject: __exit --> __init
>
> drivers/video/backlight/ep93xx_bl.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/video/backlight/ep93xx_bl.c b/drivers/video/backlight/ep93xx_bl.c
> index ef3e21e..fd073b2 100644
> --- a/drivers/video/backlight/ep93xx_bl.c
> +++ b/drivers/video/backlight/ep93xx_bl.c
> @@ -60,7 +60,7 @@ static const struct backlight_ops ep93xxbl_ops = {
> .get_brightness = ep93xxbl_get_brightness,
> };
>
> -static int __init ep93xxbl_probe(struct platform_device *dev)
> +static int ep93xxbl_probe(struct platform_device *dev)
> {
> struct ep93xxbl *ep93xxbl;
> struct backlight_device *bl;
>
prev parent reply other threads:[~2013-03-05 22:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-04 8:56 [PATCH] backlight: ep93xx_bl: remove incorrect __exit annotation Jingoo Han
2013-03-04 8:59 ` Jingoo Han
2013-03-04 9:02 ` [PATCH V2] backlight: ep93xx_bl: remove incorrect __init annotation Jingoo Han
2013-03-05 22:41 ` Ryan Mallon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=513674B2.6040106@gmail.com \
--to=rmallon@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=jg1.han@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rpurdie@rpsys.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.