From: Tom Rini <trini@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] usb:composite:fix Provide function data when addressing device with only one interface
Date: Tue, 5 Mar 2013 18:44:19 -0500 [thread overview]
Message-ID: <51368353.1010607@ti.com> (raw)
In-Reply-To: <201303060024.51526.marex@denx.de>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 03/05/2013 06:24 PM, Marek Vasut wrote:
> Dear Lukasz Majewski,
>
>> Hi Marek,
>>
>>> Dear Lukasz Majewski,
>>>
>>>> This commit fixes problems with some non-standard requests
>>>> send with device address instead of interface address
>>>> (bmRequestType.Receipent field).
>>>>
>>>> This happens with dfu-util (debian version: 0.5), which
>>>> address non standard requests (like w_value=0x21 and
>>>> bRequest=GET_DESCRIPTOR) to device. Without this fix, the
>>>> above request is STALLED, and hence causes dfu-util to assume
>>>> some standard configuration (packet size = 1024B instead of
>>>> 4096B) In turn it displays following errors: Error obtaining
>>>> DFU functional descriptor Warning: Assuming DFU version 1.0
>>>> Warning: Transfer size can not be detected ... Warning:
>>>> Trying default transfer size 1024
>>>>
>>>> This fix allows passing non-standard request to function
>>>> setup code, where it shall be handled.
>>>>
>>>> Tested at: Trats (exynos4210) Tested with:DFU and UMS
>>>> gadgets
>>>
>>> Can you please repost all the patches you want applied on
>>> u-boot-usb ? I'm completely lost in all this DFU stuff.
>>
>> This is only one patch to replace patch done by Pantelis:
>>
>> Patch to replace (revert): dfu: Send correct DFU response from
>> composite_setup SHA1: fef31049fa06e516945114195eb14ac3549d0ad2
>>
>> And this shall be replaced with posted patch.
>>
>> Another patches (with UMS gadget support - done by Piotr
>> Wilczek), also shall be added to u-boot-usb tree:
>>
>> http://patchwork.ozlabs.org/patch/219744/
>> http://patchwork.ozlabs.org/patch/219746/
>> http://patchwork.ozlabs.org/patch/219745/
>
> Ok, please check the u-boot-usb ... if it's OK, I will send Tom a
> pullrq (finally). Tom, do you still accept those for .04 ?
As of earlier in the day it still had Pantelis' patch for sending
files larger than memory which breaks all filesystem-based writes, so
that needs to go. Lukasz and I are discussing how to deal with that.
- --
Tom
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/
iQIcBAEBAgAGBQJRNoNSAAoJENk4IS6UOR1WnDkP+QE7ihcrFz0u5v2wAhkjwtaZ
etpl6oL/rB7jA6jK9zDYkyoc/Bf9A9/ffxsfGruP8kzjK2BTwHizs/Hz4I8Z90k6
6g4S7DUY4kx9t20Iyyswwuo8Bs0MXuEyDSS1a3kWXsB1110eUXd6xBsQoOKv5BeK
1UO29ZFMRJAnIpKBSrrGNE0e8xG8fnF1y8/Wos8OAk240DKoMPTF1lZEB5TEkbtN
7xePk4XLGClePj8CH8iIBj2YDo5kjRPUCZ2zSd6niayVrp5On5as+Fn9XTvWiQYG
UjLDbeAhNinzRJx9q8sB2dxXq2sSh+8ehtKZgnQCwOuj0bV0Ok4um0FP7DKN1Z+K
COvJdKC629rZ9cyc/kLfXtJzEYBJwK+OsLjLHOf7YuuhQpcPcugZWmdc8LZt6QMA
aL61JGTCfF80PVO8jAjWkJjniTHTSQRL+Adt91wej9D8e246/SbzFMqjjpTWQvVB
RcR6fUwKdcMwT+RKAJybYH8z3tqwiRQXleBPs6NqcRYV7E8AHzpeMUh5v7m2Gz/P
8y+ea4v8Nglq79UnYmeqCHmvMO0ZqUpb8/+hB35xfkyuIHstx3J784NHOaQ7IZqj
iJZ/Stf3De+ASddDFeAldoyc3EdT2k98gYUKpitExTOB5EbWKrK781JOEC0q+iSb
+xUyux8npF6Rhhf55Rm7
=DAuM
-----END PGP SIGNATURE-----
next prev parent reply other threads:[~2013-03-05 23:44 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-01 14:30 [U-Boot] [PATCH] usb:composite:fix Provide function data when addressing device with only one interface Lukasz Majewski
2013-03-01 14:34 ` Marek Vasut
2013-03-01 15:34 ` Lukasz Majewski
2013-03-05 23:24 ` Marek Vasut
2013-03-05 23:44 ` Tom Rini [this message]
2013-03-05 23:54 ` Marek Vasut
2013-03-06 0:26 ` Tom Rini
2013-03-06 0:55 ` Marek Vasut
2013-03-06 1:38 ` Tom Rini
2013-03-06 7:42 ` Lukasz Majewski
2013-03-06 7:45 ` Pantelis Antoniou
2013-03-06 13:03 ` Tom Rini
2013-03-01 16:46 ` Tom Rini
2013-06-27 21:36 ` Tormod Volden
2013-07-01 6:28 ` Lukasz Majewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51368353.1010607@ti.com \
--to=trini@ti.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.