From: Johannes Sixt <j.sixt@viscovery.net>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: git@vger.kernel.org, kernel@pengutronix.de
Subject: Re: feature suggestion: improve rerere
Date: Wed, 06 Mar 2013 14:24:18 +0100 [thread overview]
Message-ID: <51374382.6050101@viscovery.net> (raw)
In-Reply-To: <20130306101640.GA15375@pengutronix.de>
Am 3/6/2013 11:16, schrieb Uwe Kleine-König:
> ++<<<<<<< ours
> +ssize_t xread(int fd, void *buf, size_t count)
> +{
> + ssize_t ret, done = 0;
> +
> +retry:
> + ret = read(fd, buf + done, count - done);
> + if (ret < 0)
> + return ret;
> +
> + done += ret;
> +
> + if (ret == 0 /* EOF */ || done == count)
> + return done;
> + else
> + goto retry;
> +}
> +
> ++||||||| base
> ++=======
> + #include "common.h"
> +
> ++>>>>>>> theirs
> int main(int argc,char *argv[])
> {
> int fd, val, ret, size, wrote, len;
>
> This is the same conflict as the first one, just with ours and theirs
> exchanged. So my suggestion is to make rerere use the resolution
> recorded for the first conflict here.
>
> Sounds sensible?
Of course, and rerere already does it. But only when you use git's default
conflict markers rather than diff3 style markers that have this extra
||||| line.
-- Hannes
next prev parent reply other threads:[~2013-03-06 13:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-06 10:16 feature suggestion: improve rerere Uwe Kleine-König
2013-03-06 13:24 ` Johannes Sixt [this message]
2013-03-06 14:42 ` Uwe Kleine-König
2013-03-07 7:05 ` Johannes Sixt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51374382.6050101@viscovery.net \
--to=j.sixt@viscovery.net \
--cc=git@vger.kernel.org \
--cc=kernel@pengutronix.de \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.