From: Jiri Slaby <jslaby@suse.cz>
To: Peter Hurley <peter@hurleysoftware.com>
Cc: jhovold@gmail.com,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Alan Stern <stern@rowland.harvard.edu>,
USB list <linux-usb@vger.kernel.org>,
linux-serial@vger.kernel.org, Alan Cox <alan@lxorguk.ukuu.org.uk>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [Fwd: [PATCH v2 0/4] TTY: port hangup and close fixes]
Date: Wed, 06 Mar 2013 17:23:11 +0100 [thread overview]
Message-ID: <51376D6F.1070202@suse.cz> (raw)
In-Reply-To: <1362522724.18799.149.camel@thor.lan>
On 03/05/2013 11:32 PM, Peter Hurley wrote:
>> So I'm thinking about
>> something like this:
>>
>> if (port->tty)
>> set_bit(TTY_IO_ERROR, &port->tty->flags);
>> tty = port->tty; <=== take a snapshot
>> spin_unlock_irqrestore(&port->lock, flags);
>> tty_port_shutdown(port, tty); <=== use the snapshot
>> set_tty_port(port, NULL); <=== put kref on that tty
>
> Yeah, that's better.
But still not correct. The tty can be invalid (freed) at the time
tty_port_shutdown is called. We should take a real reference inside the
lock and put the reference explicitly after the call.
--
js
suse labs
next prev parent reply other threads:[~2013-03-06 16:22 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1362085054.3337.20.camel@thor.lan>
2013-03-05 16:02 ` [Fwd: [PATCH v2 0/4] TTY: port hangup and close fixes] Jiri Slaby
2013-03-05 17:06 ` Peter Hurley
[not found] ` <1362503170.18799.33.camel-AsKIXgLx6sE@public.gmane.org>
2013-03-05 21:56 ` Jiri Slaby
2013-03-05 21:56 ` Jiri Slaby
2013-03-05 22:02 ` Peter Hurley
2013-03-05 22:10 ` Jiri Slaby
2013-03-05 22:32 ` Peter Hurley
2013-03-06 16:23 ` Jiri Slaby [this message]
2013-03-06 16:52 ` Johan Hovold
2013-03-06 19:14 ` Peter Hurley
[not found] ` <1362597296.18799.198.camel-AsKIXgLx6sE@public.gmane.org>
2013-03-07 9:43 ` Johan Hovold
2013-03-07 9:43 ` Johan Hovold
2013-03-07 21:52 ` Peter Hurley
[not found] ` <51361724.4050107-AlSwsSmVLrQ@public.gmane.org>
2013-03-07 14:55 ` [PATCH v3 0/6] TTY: port hangup and close fixes Johan Hovold
2013-03-07 14:55 ` Johan Hovold
[not found] ` <1362668153-10972-1-git-send-email-jhovold-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2013-03-07 14:55 ` [PATCH v3 1/6] TTY: clean up port shutdown Johan Hovold
2013-03-07 14:55 ` Johan Hovold
2013-03-07 14:55 ` [PATCH v3 2/6] TTY: wake up processes last at hangup Johan Hovold
2013-03-07 14:55 ` [PATCH v3 3/6] TTY: fix DTR being raised on hang up Johan Hovold
2013-03-13 19:43 ` Peter Hurley
[not found] ` <1363203823.25976.102.camel-AsKIXgLx6sE@public.gmane.org>
2013-03-15 9:24 ` Johan Hovold
2013-03-15 9:24 ` Johan Hovold
2013-03-15 11:03 ` Peter Hurley
2013-03-15 11:03 ` Peter Hurley
2013-03-15 11:30 ` Johan Hovold
2013-03-15 11:57 ` Peter Hurley
2013-03-07 14:55 ` [PATCH v3 4/6] TTY: fix DTR not being dropped " Johan Hovold
2013-03-07 14:55 ` [PATCH v3 5/6] TTY: clean up port drain-delay handling Johan Hovold
2013-03-07 14:55 ` [PATCH v3 6/6] TTY: fix close of uninitialised ports Johan Hovold
2013-03-13 19:50 ` [PATCH v3 0/6] TTY: port hangup and close fixes Peter Hurley
2013-03-15 9:29 ` Johan Hovold
2013-03-15 19:05 ` Greg Kroah-Hartman
2013-03-15 19:42 ` Johan Hovold
2013-03-18 23:28 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51376D6F.1070202@suse.cz \
--to=jslaby@suse.cz \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=gregkh@linuxfoundation.org \
--cc=jhovold@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=peter@hurleysoftware.com \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.