From: Hector Palacios <hector.palacios-i7dp0qKlBMg@public.gmane.org>
To: devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org
Cc: "fabio.estevam-KZfg59tc24xl57MIdRCFDg@public.gmane.org"
<fabio.estevam-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
Subject: doubt about where to put pin-mux in MX28 based platform DT
Date: Wed, 6 Mar 2013 18:02:23 +0100 [thread overview]
Message-ID: <5137769F.1000308@digi.com> (raw)
Hello,
I'm creating the DT for a custom platform based on Freescale MX28 CPU and I have some
doubts about where to add some pin mux configurations: whether in imx28.dtsi or in my
platform dts.
A pair of examples folow:
Example #1. My platform is using a valid IOMUX for DUART TX/RX lines which is not
covered in imx28.dtsi, namely the I2C0 pins. Since this is a valid IOMUX that can be
used by other platforms, I'd say I should included it in imx28.dtsi:
diff --git a/arch/arm/boot/dts/imx28.dtsi b/arch/arm/boot/dts/imx28.dtsi
index 3fa6d19..8928b7b 100644
--- a/arch/arm/boot/dts/imx28.dtsi
+++ b/arch/arm/boot/dts/imx28.dtsi
@@ -186,6 +186,17 @@
fsl,pull-up = <0>;
};
+ duart_pins_c: duart@2 {
+ reg = <2>;
+ fsl,pinmux-ids = <
+ 0x3182 /* MX28_PAD_I2C0_SCL__DUART_RX */
+ 0x3192 /* MX28_PAD_I2C0_SDA__DUART_TX */
+ >;
+ fsl,drive-strength = <0>;
+ fsl,voltage = <1>;
+ fsl,pull-up = <0>;
+ };
+
duart_4pins_a: duart-4pins@0 {
reg = <0>;
fsl,pinmux-ids = <
Example #2. My platform assembles a NAND chip which is powered at 1.8V. The imx28.dtsi
has a configuration 'gpmi_pins_a: gpmi-nand@0' that configures the pins at 3.3V.
Should I create another entry here 'gpmi_pins_b: gpmi-nand@1' with fsl,voltage = <0>;
or should I create a specific entry in my platform's DT instead?
What is the convention?
--
Héctor Palacios
next reply other threads:[~2013-03-06 17:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-06 17:02 Hector Palacios [this message]
2013-03-07 13:06 ` doubt about where to put pin-mux in MX28 based platform DT Maxime Ripard
2013-03-07 13:06 ` Maxime Ripard
[not found] ` <513890D3.5060905-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
2013-03-21 16:57 ` Hector Palacios
[not found] ` <514B3C15.8080103-i7dp0qKlBMg@public.gmane.org>
2013-03-22 13:28 ` Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5137769F.1000308@digi.com \
--to=hector.palacios-i7dp0qklbmg@public.gmane.org \
--cc=devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org \
--cc=fabio.estevam-KZfg59tc24xl57MIdRCFDg@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.