All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Asias He <asias@redhat.com>
Cc: kvm@vger.kernel.org, "Michael S. Tsirkin" <mst@redhat.com>,
	virtualization@lists.linux-foundation.org,
	target-devel@vger.kernel.org,
	Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [PATCH] tcm_vhost: Add hotplug/hotunplug support
Date: Wed, 06 Mar 2013 18:41:47 +0100	[thread overview]
Message-ID: <51377FDB.1080605@redhat.com> (raw)
In-Reply-To: <20130306012811.GA20372@hj.localdomain>

Il 06/03/2013 02:28, Asias He ha scritto:
>> > This can queue up quite a bit of memory if the handler thread
>> > is delayed, no? Can we limit the # of outstanding events?
>> > Will guest recover from a missed event?
> Hmm, good point. Will limit the number. The size of 'struct
> tcm_vhost_evt' is around 20 bytes. So if we limit it to 128, it is ~2.5K
> of memory.
> 
> Paolo, if we limit the number of outstanding events and set
> vs->vs_events_dropped, the guest will recover from a missed event, right?

Yes.  At least it should (it doesn't yet).

Paolo

  reply	other threads:[~2013-03-06 17:41 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-05  9:17 [PATCH] tcm_vhost: Add hotplug/hotunplug support Asias He
2013-03-05  9:31 ` Wanlong Gao
2013-03-06  1:29   ` Asias He
2013-03-06  1:29   ` Asias He
2013-03-05 12:11 ` Michael S. Tsirkin
2013-03-05 13:21   ` Paolo Bonzini
2013-03-05 14:34     ` Michael S. Tsirkin
2013-03-05 22:51       ` Nicholas A. Bellinger
2013-03-06 14:28         ` Paolo Bonzini
2013-03-07  0:55           ` Asias He
2013-03-07 22:45             ` Nicholas A. Bellinger
2013-03-07 22:45             ` Nicholas A. Bellinger
2013-03-08  2:26               ` Asias He
2013-03-05 22:51       ` Nicholas A. Bellinger
2013-03-06  1:40       ` Asias He
2013-03-06  1:28   ` Asias He
2013-03-06 17:41     ` Paolo Bonzini [this message]
2013-03-07  0:36       ` Asias He
  -- strict thread matches above, loose matches on Subject: below --
2013-03-05  9:17 Asias He

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51377FDB.1080605@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=asias@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=mst@redhat.com \
    --cc=stefanha@redhat.com \
    --cc=target-devel@vger.kernel.org \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.