From: Eric Blake <eblake@redhat.com>
To: Juan Quintela <quintela@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v2] migration: Improve QMP documentation
Date: Wed, 06 Mar 2013 11:34:06 -0700 [thread overview]
Message-ID: <51378C1E.6060904@redhat.com> (raw)
In-Reply-To: <1362594402-6917-1-git-send-email-quintela@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 815 bytes --]
On 03/06/2013 11:26 AM, Juan Quintela wrote:
> v2:
> Add Markus sugestions:
If you keep this in the commit message, then
s/sugestions/suggestions/
>
> Signed-off-by: Juan Quintela <quintela@redhat.com>
> ---
But it's better to stick patch changelog (your v2 comment) here, after
the ---, since it is nice for reviewers but useless information in the
git logs.
> + - "duplicate": number of pages filled entirely with the same
> + byte (json-int)
> + These are sent over the wire much more efficiently.
TAB damage.
Contents look fine, so once the commit message and whitespace is fixed,
feel free to add:
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 621 bytes --]
next prev parent reply other threads:[~2013-03-06 18:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-06 18:26 [Qemu-devel] [PATCH v2] migration: Improve QMP documentation Juan Quintela
2013-03-06 18:34 ` Eric Blake [this message]
2013-03-07 13:12 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51378C1E.6060904@redhat.com \
--to=eblake@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.