From: Dave Hansen <dave@linux.vnet.ibm.com>
To: Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>
Cc: bp@alien8.de, hpa@linux.intel.com, linux-kernel@vger.kernel.org
Subject: Re: [3.9-rc1 x86] Bug in ioremap code?
Date: Wed, 06 Mar 2013 15:17:18 -0800 [thread overview]
Message-ID: <5137CE7E.8050403@linux.vnet.ibm.com> (raw)
In-Reply-To: <513787BB.4040504@linux.vnet.ibm.com>
On 03/06/2013 10:15 AM, Dave Hansen wrote:
> Does anybody know what this business is in __cpa_process_fault()?
>
>> /*
>> * Ignore the NULL PTE for kernel identity mapping, as it is expected
>> * to have holes.
>> * Also set numpages to '1' indicating that we processed cpa req for
>> * one virtual address page and its pfn. TBD: numpages can be set based
>> * on the initial value and the level returned by lookup_address().
>> */
>
> If this is expecting the identity mapping to have holes, then the
> BUG_ON() is wrong. But how would it _get_ holes?
The holes in question were part of the PCI space. The ioremap code was
trying to keep the kernel identity map in sync with the mappings that it
had made. But, in the process, it called __pa() on a virtual address
that was part of one of those holes. I'm not _quite_ sure what the
fallout is from trying to sync a nonexistent map, but it surely wasn't
an intended or good thing to be doing.
A patch to fix it should be on the way. Tetsuo, can you apply it and
see if it helps you?
next prev parent reply other threads:[~2013-03-06 23:19 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-05 15:35 [linux-next-20130205] Bug in bootup code or debug code? Tetsuo Handa
2013-03-04 15:15 ` [3.9-rc1] " Tetsuo Handa
2013-03-05 11:31 ` [3.9-rc1 x86/microcode] Bug in CONFIG_MICROCODE_INTEL_EARLY=y Tetsuo Handa
2013-03-05 15:41 ` [3.9-rc1 x86] Bug in ioremap code? Tetsuo Handa
2013-03-05 18:06 ` Borislav Petkov
2013-03-05 21:28 ` Tetsuo Handa
2013-03-05 22:15 ` H. Peter Anvin
2013-03-05 23:46 ` Dave Hansen
2013-03-05 23:58 ` H. Peter Anvin
2013-03-06 0:39 ` Yu, Fenghua
2013-03-06 1:12 ` Yu, Fenghua
2013-03-06 1:35 ` H. Peter Anvin
2013-03-05 22:26 ` Dave Hansen
2013-03-05 22:44 ` Borislav Petkov
2013-03-06 0:22 ` Dave Hansen
2013-03-06 10:16 ` Tetsuo Handa
2013-03-06 11:16 ` H. Peter Anvin
2013-03-06 14:58 ` Tetsuo Handa
2013-03-06 15:44 ` Dave Hansen
2013-03-06 17:51 ` Dave Hansen
2013-03-06 18:15 ` Dave Hansen
2013-03-06 23:17 ` Dave Hansen [this message]
2013-03-13 13:24 ` [3.9-rc1] Bug in bootup code or debug code? Tetsuo Handa
2013-03-13 15:22 ` Yu, Fenghua
2013-03-13 17:44 ` H. Peter Anvin
2013-03-13 20:45 ` Tetsuo Handa
2013-03-19 22:12 ` Yu, Fenghua
2013-03-20 14:24 ` Shaun Ruffell
2013-03-20 16:32 ` Yu, Fenghua
2013-03-20 17:03 ` Shaun Ruffell
2013-03-20 17:05 ` Yu, Fenghua
2013-03-20 17:14 ` Shaun Ruffell
2013-03-22 1:24 ` [tip:x86/urgent] x86, microcode_intel_early: Mark apply_microcode_early() as cpuinit tip-bot for H. Peter Anvin
2013-03-13 17:45 ` [3.9-rc1] Bug in bootup code or debug code? H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5137CE7E.8050403@linux.vnet.ibm.com \
--to=dave@linux.vnet.ibm.com \
--cc=bp@alien8.de \
--cc=hpa@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=penguin-kernel@i-love.sakura.ne.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.