On 04.03.2013 05:07, Nickolai Zeldovich wrote:

> read_terminal_list() and read_crypto_list() both call
> 
>   cur->name = grub_strdup (name);
> 
> and both incorrectly check whether it failed by using "if (!name)"
> instead of "if (!cur->name)".  The patch below fixes these two issues.
> 

Applied thanks. Your patch was garbled though. Please send as text
attachement next time.

> Nickolai.
> 
> ---
> 
> --- grub-core/normal/crypto.c    2012-03-11 13:43:18 +0000
> +++ grub-core/normal/crypto.c    2013-03-04 03:46:35 +0000
> @@ -136,7 +136,7 @@
>      }
> 
>        cur->name = grub_strdup (name);
> -      if (! name)
> +      if (! cur->name)
>      {
>        grub_errno = GRUB_ERR_NONE;
>        grub_free (cur);
> 
> --- grub-core/normal/term.c    2013-03-02 10:47:59 +0000
> +++ grub-core/normal/term.c    2013-03-04 03:46:23 +0000
> @@ -389,7 +389,7 @@
>      }
> 
>        cur->name = grub_strdup (name);
> -      if (! name)
> +      if (! cur->name)
>      {
>        grub_errno = GRUB_ERR_NONE;
>        grub_free (cur);
> 
> 
> _______________________________________________
> Grub-devel mailing list
> Grub-devel@gnu.org
> https://lists.gnu.org/mailman/listinfo/grub-devel
>