From: Sylwester Nawrocki <s.nawrocki@samsung.com>
To: Shaik Ameer Basha <shaik.samsung@gmail.com>
Cc: Arun Kumar K <arun.kk@samsung.com>,
linux-media@vger.kernel.org, k.debski@samsung.com,
jtp.park@samsung.com, s.nawrocki@samsung.com
Subject: Re: [PATCH] [media] s5p-mfc: Fix encoder control 15 issue
Date: Thu, 07 Mar 2013 11:49:06 +0100 [thread overview]
Message-ID: <513870A2.7090209@samsung.com> (raw)
In-Reply-To: <CAOD6ATpeNvnAsTL+j17d3W-SZr0gXAk07AsXqo+HWW50N7V1_g@mail.gmail.com>
On 03/07/2013 03:20 AM, Shaik Ameer Basha wrote:
> v4l2_ctrl_new() uses check_range() for control range checking (which
> is added newly).
> This function expects 'step' value for V4L2_CTRL_TYPE_BOOLEAN type control.
> If 'step' value doesn't match to '1', it returns -ERANGE error.
>
> Its a change in v4l2 core.
Yes, I suspected the issue appeared after recent change
commit 88e85861b4f77ae29495ee05574c98dd0c6c3037
[media] v4l2-ctrl: Add helper function for the controls range update
Then it is related to to 3.9-rc1+ kernels only. I have verified it on
3.8 based kernel and there is no issue with drivers that do not
initialize step value for boolean type controls properly. It only
appears after the above commit is applied.
I've picked your fixup patches into v3.9-fixes branch and will try
to send them out this week, together with other patches from our side.
Regards,
Sylwester
next prev parent reply other threads:[~2013-03-07 10:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-06 13:15 [PATCH] [media] s5p-mfc: Fix encoder control 15 issue Arun Kumar K
2013-03-06 22:10 ` Sylwester Nawrocki
2013-03-07 2:20 ` Shaik Ameer Basha
2013-03-07 10:49 ` Sylwester Nawrocki [this message]
2013-03-07 4:23 ` Arun Kumar K
2013-03-07 10:51 ` Sylwester Nawrocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=513870A2.7090209@samsung.com \
--to=s.nawrocki@samsung.com \
--cc=arun.kk@samsung.com \
--cc=jtp.park@samsung.com \
--cc=k.debski@samsung.com \
--cc=linux-media@vger.kernel.org \
--cc=shaik.samsung@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.