From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: Re: [PATCH] tools/xenconsoled: Initialise pointers
 before trying to use them
Date: Thu, 7 Mar 2013 15:57:27 +0000
Message-ID: <5138B8E7.3060105@citrix.com>
References: <f66d74cbf49244d97957.1362669196@andrewcoop.uk.xensource.com>
	<20130307152828.GA28806@aepfle.de>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <20130307152828.GA28806@aepfle.de>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Olaf Hering <olaf@aepfle.de>
Cc: Ian Jackson <Ian.Jackson@eu.citrix.com>, Wei Liu <wei.liu2@citrix.com>, Ian Campbell <Ian.Campbell@citrix.com>, Marcus Granado <Marcus.Granado@eu.citrix.com>, "xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
List-Id: xen-devel@lists.xenproject.org

On 07/03/13 15:28, Olaf Hering wrote:
> On Thu, Mar 07, Andrew Cooper wrote:
>
>> This is a regression introduced by
>>
>> "Switch from select() to poll() in xenconsoled's IO loop."
>>   hg c/s 26405:7359c3122c5d
>>   git cc5434c933153c4b8812d1df901f8915c22830a8
>>
>> which results in reliable segfaults during VM power operations.
> What about switching to calloc(3), given that many members are zeroed
> anyway?
>
> Olaf

That also works, and is better going forwards.  V2 on its way.