From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:33977) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UDdpa-0005C4-Fp for qemu-devel@nongnu.org; Thu, 07 Mar 2013 11:38:12 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UDdpV-0008NS-EY for qemu-devel@nongnu.org; Thu, 07 Mar 2013 11:38:10 -0500 Received: from cantor2.suse.de ([195.135.220.15]:44351 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UDdpV-0008NL-5X for qemu-devel@nongnu.org; Thu, 07 Mar 2013 11:38:05 -0500 Message-ID: <5138C26B.5010408@suse.de> Date: Thu, 07 Mar 2013 17:38:03 +0100 From: =?ISO-8859-1?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1360108037-9211-1-git-send-email-jlarrew@linux.vnet.ibm.com> <1360108037-9211-3-git-send-email-jlarrew@linux.vnet.ibm.com> <513621F7.9030403@suse.de> <51362575.2000908@de.ibm.com> <87621319kc.fsf@codemonkey.ws> <5138C007.6080305@de.ibm.com> In-Reply-To: <5138C007.6080305@de.ibm.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 2/3] hw/virtio-net.c: set config size using host features List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Christian Borntraeger , Anthony Liguori Cc: Alexander Graf , "Michael S. Tsirkin" , Stefan Hajnoczi , Jesse Larrew , qemu-devel@nongnu.org, Jens Freimann , Cornelia Huck Am 07.03.2013 17:27, schrieb Christian Borntraeger: >> It's a bug in both virtio-ccw that features=3D0 when get_features is >> called. You can also tell this with: >> >> [10:02 AM] anthony@titi:~/git/qemu/hw/s390x$ grep DEFINE_VIRTIO_NET_FE= ATURES * >> virtio-ccw.c: DEFINE_VIRTIO_NET_FEATURES(VirtioCcwDevice, host_feat= ures[0]), >> >> So virtio-s390 is doing it wrong, but virtio-ccw looks like its doing = it >> right. >=20 > At least, this patch seems to work. (That also implies, that a transpor= t > must not hide virtio feature bits). To me it indicates that the use of the old qdev property setters is hiding errors resulting from trying to set not-existing properties. If we would set the properties in a way that gets us an Error* on failure like the object_property_set_*() do, we would notice on machine creation (or device_add). Andreas >=20 >=20 > From: Christian Borntraeger > Date: Thu, 7 Mar 2013 17:21:41 +0100 > Subject: [PATCH] Allow virtio-net features for legacy s390 virtio bus >=20 > Enable all virtio-net features for the legacy s390 virtio bus. > This also fixes > kernel BUG at /usr/src/packages/BUILD/kernel-default-3.0.58/linux-3.0/d= rivers/s390/kvm/kvm_virtio.c:121! >=20 > Signed-off-by: Christian Borntraeger > --- > hw/s390x/s390-virtio-bus.c | 1 + > 1 file changed, 1 insertion(+) >=20 > diff --git a/hw/s390x/s390-virtio-bus.c b/hw/s390x/s390-virtio-bus.c > index 1200691..a8a8e19 100644 > --- a/hw/s390x/s390-virtio-bus.c > +++ b/hw/s390x/s390-virtio-bus.c > @@ -399,6 +399,7 @@ static const VirtIOBindings virtio_s390_bindings =3D= { > =20 > static Property s390_virtio_net_properties[] =3D { > DEFINE_NIC_PROPERTIES(VirtIOS390Device, nic), > + DEFINE_VIRTIO_NET_FEATURES(VirtIOS390Device, host_features), > DEFINE_PROP_UINT32("x-txtimer", VirtIOS390Device, > net.txtimer, TX_TIMER_INTERVAL), > DEFINE_PROP_INT32("x-txburst", VirtIOS390Device, >=20 --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg