From: Andrew Wong <andrew.kw.w@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] setup.c: Fix prefix_pathspec from looping pass end of string
Date: Thu, 07 Mar 2013 20:58:34 -0500 [thread overview]
Message-ID: <513945CA.6070302@gmail.com> (raw)
In-Reply-To: <7vk3pik6aq.fsf@alter.siamese.dyndns.org>
On 03/07/13 20:51, Junio C Hamano wrote:
> But it is equally broken to behave as if there is nothing wrong in
> the incomplete magic ":(top" that is not closed, isn't it?
Ah, yea, I did notice that, but then I saw a few lines below:
if (*copyfrom == ')')
copyfrom++;
which is explicitly making the ")" optional. So I thought maybe that was
the original intention, and left it at that. Though the doc says to end
with ")", so I guess it should error out after all? If that's the case,
I can try to come up with a patch to error it out (through die() ?).
next prev parent reply other threads:[~2013-03-08 2:03 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-07 16:36 [PATCH] setup.c: Fix prefix_pathspec from looping pass end of string Andrew Wong
2013-03-07 21:48 ` Junio C Hamano
2013-03-07 22:25 ` Andrew Wong
2013-03-07 23:59 ` Junio C Hamano
2013-03-08 0:25 ` Andrew Wong
2013-03-08 1:51 ` Junio C Hamano
2013-03-08 1:58 ` Andrew Wong [this message]
2013-03-09 23:45 ` [PATCH 1/2] " Andrew Wong
2013-03-09 23:46 ` [PATCH 2/2] setup.c: Check that the pathspec magic ends with ")" Andrew Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=513945CA.6070302@gmail.com \
--to=andrew.kw.w@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.